Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require-pr-label.yml should not be executed on forks #114790

Closed
sobolevn opened this issue Jan 31, 2024 · 0 comments
Closed

require-pr-label.yml should not be executed on forks #114790

sobolevn opened this issue Jan 31, 2024 · 0 comments
Assignees
@sobolevn

Comments

@sobolevn
Copy link
Member

sobolevn commented Jan 31, 2024 •
edited by bedevere-app bot
Loading

It does not make much sense to execute it on forks, because it is a workflow specific for python/cpython only.

Here's an example PR on my own fork:

Снимок экрана 2024-01-31 в 11 58 56

I think that it does make sense to add if: github.repository == 'python/cpython' to it, so it can be safely skipped on forks.

Linked PRs
@sobolevn sobolevn self-assigned this Jan 31, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue Jan 31, 2024
@sobolevn
pythongh-114790: Do not execute workflows/require-pr-label.yml on f…
90e94f8 
…orks
@bedevere-app bedevere-app bot mentioned this issue Jan 31, 2024
Merged
hugovk added a commit that referenced this issue Jan 31, 2024
@sobolevn @hugovk
gh-114790: Do not execute workflows/require-pr-label.yml on forks (#…
1c2ea8b 
…114791)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 31, 2024
@sobolevn @hugovk @miss-islington
pythongh-114790: Do not execute workflows/require-pr-label.yml on f…
76bb400 
…orks (pythonGH-114791)

(cherry picked from commit 1c2ea8b)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 31, 2024
@sobolevn @hugovk @miss-islington
pythongh-114790: Do not execute workflows/require-pr-label.yml on f…
bc14743 
…orks (pythonGH-114791)

(cherry picked from commit 1c2ea8b)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This was referenced Jan 31, 2024
Merged
Merged
hugovk added a commit that referenced this issue Jan 31, 2024
@miss-islington @sobolevn @hugovk
[3.12] gh-114790: Do not execute workflows/require-pr-label.yml on …
3e06cce 
…forks (GH-114791) (#114800)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit that referenced this issue Jan 31, 2024
@miss-islington @sobolevn @hugovk
[3.11] gh-114790: Do not execute workflows/require-pr-label.yml on …
8e323cb 
…forks (GH-114791) (#114801)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovk hugovk closed this as completed Jan 31, 2024
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@sobolevn @hugovk @aisk
pythongh-114790: Do not execute workflows/require-pr-label.yml on f…
20110af 
…orks (python#114791)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hugovk @sobolevn