Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Download page translatable #122384

Closed
rffontenelle opened this issue Jul 29, 2024 · 6 comments
Closed

Make Download page translatable #122384

rffontenelle opened this issue Jul 29, 2024 · 6 comments
Labels
docs Documentation in the Doc dir

Comments

@rffontenelle
Copy link
Contributor

rffontenelle commented Jul 29, 2024 •
edited by bedevere-app bot
Loading

Documentation

The Python docs' Download page (https://docs.python.org/3/download.html) is not currently available for translation, hence differentiating from other pages that received the translations effort of the language teams.

Strings should be marked for translation, so the file's strings are properly extracted into translation files.

To reproduce:

  1. make -C Doc venv gettext # from local CPython checkout
  2. search (unsuccessfully) strings in the .pot files generate in 'Doc/build/gettext/' directory for the translation strings that should be extracted from 'Doc/tools/templates/download.html' file (e.g. grep -R 'These archives contain all the content in the documentation.' Doc/build/gettext)

Linked PRs
@rffontenelle rffontenelle added the docs Documentation in the Doc dir label Jul 29, 2024
@bedevere-app bedevere-app bot mentioned this issue Jul 29, 2024
Merged
@Wulian233
Copy link
Contributor

A similar problem appears in the footer of every page. I tried to search for keywords, but couldn't find anything relevant.

IMG_20240729_141406.jpg

@hugovk
Copy link
Member

hugovk commented Jul 29, 2024

Some of that comes from the theme, for example: https://github.com/python/python-docs-theme/blob/f1ba0f8c86f859be2a800fae8af00ec4a7e48039/python_docs_theme/layout.html#L147

@Wulian233
Copy link
Contributor

looks there has {% trans %}{% endtrans %}, and I've switched a lot of different languages, but there's no actual translation 🤔🤔❓

@rffontenelle
Copy link
Contributor Author

rffontenelle commented Jul 29, 2024 •
edited
Loading

python-doc-theme is not being translated. It is a separate repository, and translators only translate the documentation from cpython repository. This should probably change.

hugovk added a commit that referenced this issue Aug 1, 2024
@rffontenelle @hugovk
gh-122384: Mark strings from Download page for translation (#122385)
58ffc4c 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 1, 2024
@rffontenelle @hugovk @miss-islington
pythongh-122384: Mark strings from Download page for translation (pyt…
7d8b2e3 
…honGH-122385)

(cherry picked from commit 58ffc4c)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 1, 2024
@rffontenelle @hugovk @miss-islington
pythongh-122384: Mark strings from Download page for translation (pyt…
82cc3a6 
…honGH-122385)

(cherry picked from commit 58ffc4c)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This was referenced Aug 1, 2024
Merged
Merged
@hugovk hugovk closed this as completed Aug 1, 2024
@hugovk
Copy link
Member

hugovk commented Aug 1, 2024

See python/python-docs-theme#194 for localising the theme.

hugovk added a commit that referenced this issue Aug 1, 2024
@miss-islington @rffontenelle @hugovk
[3.12] gh-122384: Mark strings from Download page for translation (GH…
fed70e0 
…-122385) (#122554)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit that referenced this issue Aug 1, 2024
@miss-islington @rffontenelle @hugovk
[3.13] gh-122384: Mark strings from Download page for translation (GH…
be970f6 
…-122385) (#122553)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@Wulian233
Copy link
Contributor

Good

blhsing pushed a commit to blhsing/cpython that referenced this issue Aug 22, 2024
@rffontenelle @hugovk @blhsing
pythongh-122384: Mark strings from Download page for translation (pyt…
701cd02 
…hon#122385)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hugovk @rffontenelle @Wulian233