Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate asyncio.iscoroutinefunction #122858

Closed
kumaraditya303 opened this issue Aug 9, 2024 · 3 comments
Closed

Deprecate asyncio.iscoroutinefunction #122858

kumaraditya303 opened this issue Aug 9, 2024 · 3 comments
Labels
3.14 new features, bugs and security fixes topic-asyncio

Comments

@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Aug 9, 2024 •
edited by bedevere-app bot
Loading

asyncio.iscoroutinefunction should be deprecated in favor of inspect.iscoroutinefunction, we don't need two different functions to do the same thing. I propose to deprecate asyncio.iscoroutinefunction because IMO these introspection functions don't belong to asyncio but more to inspect module. It will be deprecated in Python 3.14 and scheduled for removal in Python 3.16.

Linked PRs
@kumaraditya303 kumaraditya303 added topic-asyncio 3.14 new features, bugs and security fixes labels Aug 9, 2024
@Wulian233
Copy link
Contributor

Wulian233 commented Aug 9, 2024 •
edited
Loading

See #94923 , maybe you can review it :)

@Eclips4
Copy link
Member

Eclips4 commented Aug 9, 2024

Looks like an duplicate of #94912

@kumaraditya303
Copy link
Contributor Author

Looks like an duplicate of #94912

No it isn't, in this issue we are just deprecating it not making an alias.

@bedevere-app bedevere-app bot mentioned this issue Aug 10, 2024
Merged
kumaraditya303 added a commit that referenced this issue Aug 11, 2024
@Wulian233 @kumaraditya303
gh-122858: Deprecate asyncio.iscoroutinefunction (#122875)
bc9d92c 
Deprecate `asyncio.iscoroutinefunction` in favor of `inspect.iscoroutinefunction`.

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@kumaraditya303 kumaraditya303 mentioned this issue Aug 11, 2024
Closed
blhsing pushed a commit to blhsing/cpython that referenced this issue Aug 22, 2024
@Wulian233 @kumaraditya303 @blhsing
pythongh-122858: Deprecate asyncio.iscoroutinefunction (python#122875)
2e65db5 
Deprecate `asyncio.iscoroutinefunction` in favor of `inspect.iscoroutinefunction`.

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.14 new features, bugs and security fixes topic-asyncio
Projects
asyncio
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kumaraditya303 @Wulian233 @Eclips4