Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92123: Adapt _elementtree to multi-phase init (PEP 489) #101285

Merged
merged 28 commits into from
Jan 24, 2023
Merged

gh-92123: Adapt _elementtree to multi-phase init (PEP 489) #101285

merged 28 commits into from
Jan 24, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 24, 2023 •
edited by bedevere-bot
Loading

@erlend-aasland
Refactor: replace query with parameter
4d0b34e 
Pass state as arg to expat_set_error()
@erlend-aasland
Refactor: replace query with parameter
3489b1b 
Pass state as arg to element_setstate_from_attributes()
@erlend-aasland
Refactor: replace query with parameter
c2089ff 
Pass state as arg to element_setstate_from_Python()
@erlend-aasland
Fix cherry-picks
acafd9c
@erlend-aasland
pythongh-92123: use PyModule_GetState in _elementtree
18109aa
@erlend-aasland
Add get_elementtree_state_by_cls() helper
af83b00
@erlend-aasland
_elementtree.Element.append
96e6239
@erlend-aasland
_elementtree.Element.__copy__
27c7dd8
@erlend-aasland
_elementtree.Element.__setstate__
74eb390
@erlend-aasland
_elementtree.Element.extend
7f639a7
@erlend-aasland
_elementtree.Element.find
0b2a670
@erlend-aasland
_elementtree.Element.findtext
5502d85
@erlend-aasland
_elementtree.Element.findall
0546b43
@erlend-aasland
_elementtree.Element.iterfind
863db65
@erlend-aasland
_elementtree.Element.iter
9861b4e
@erlend-aasland
_elementtree.Element.itertext
c012ed0
@erlend-aasland
_elementtree.Element.makeelement
2aff87d
@erlend-aasland
Add get_elementtree_state_by_type() helper
e41f38f
@erlend-aasland
_elementtree_Element___deepcopy___impl
c904083
@erlend-aasland
element_setitem
26656f1
@erlend-aasland
element_ass_subscr
381c8d8
@erlend-aasland
elementiter_next
af6a4e9
@erlend-aasland
treebuilder_new
ae51faf
@erlend-aasland
xmlparser_new
85b6b96
@erlend-aasland
clinic-state
5290718
@erlend-aasland
Remove ET_STATE_GLOBAL macro
2224356
@erlend-aasland
Multi-phase init
6ca25df
@bedevere-bot bedevere-bot mentioned this pull request Jan 24, 2023
Closed
@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 24, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit de8ec94 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 24, 2023
corona10
corona10 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change iteself looks good to me.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jan 24, 2023 •
edited
Loading

Code change iteself looks good to me.

Thanks for the review; I'll merge as soon as the CI turns green. I'll give Kumar a chance to review it, so I'll wait with merging until tomorrow evening.

@erlend-aasland erlend-aasland merged commit fee7a99 into python:main Jan 24, 2023
@erlend-aasland erlend-aasland deleted the etree/multi-phase-init branch January 24, 2023 19:58
@erlend-aasland erlend-aasland mentioned this pull request Mar 14, 2023
Closed
@vstinner
Copy link
Member

vstinner commented Apr 5, 2023

Nicely done @erlend-aasland, that was a big one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @bedevere-bot @vstinner @corona10 @kumaraditya303