gh-101283: Fix use of unbound variable #101712
Conversation
zooba
commented
Feb 8, 2023
•
zooba
commented
- Issue: Undocumented risky behaviour in subprocess module #101283
|
No need for backports, as I've made the change in the original backport PRs. |
| comspec = executable | ||
|
|
||
| args = '{} /c "{}"'.format (comspec, args) |
There was a problem hiding this comment.
The value of args should quote comspec. Otherwise the shell process won't parse its command line correctly if comspec contains spaces.
There was a problem hiding this comment.
That was a problem before too, so let's make it a new issue. Assuming the backports for the original change go it, it'll automatically flow back smoothly enough (whereas this PR may not).
|
@zooba @eryksun Should this PR be backported? Especially considering that the new security releases may be issued the nearest days because of #101726 (comment):
|
|
I integrated the fix into the backports before merging them, so it's already there. |
|
Oh, I see, thank you. |
* main: (82 commits) pythongh-101670: typo fix in PyImport_ExtendInittab() (python#101723) pythonGH-99293: Document that `Py_TPFLAGS_VALID_VERSION_TAG` shouldn't be used. (#pythonGH-101736) no-issue: Add Dong-hee Na as the cjkcodecs codeowner (pythongh-101731) pythongh-101678: Merge math_1_to_whatever() and math_1() (python#101730) pythongh-101678: refactor the math module to use special functions from c11 (pythonGH-101679) pythongh-85984: Remove legacy Lib/pty.py code. (python#92365) pythongh-98831: Use opcode metadata for stack_effect() (python#101704) pythongh-101283: Version was just released, so should be changed in 3.11.3 (pythonGH-101719) pythongh-101283: Fix use of unbound variable (pythonGH-101712) pythongh-101283: Improved fallback logic for subprocess with shell=True on Windows (pythonGH-101286) pythongh-101277: Port more itertools static types to heap types (python#101304) pythongh-98831: Modernize CALL and family (python#101508) pythonGH-101696: invalidate type version tag in `_PyStaticType_Dealloc` (python#101697) pythongh-100221: Fix creating dirs in `make sharedinstall` (pythonGH-100329) pythongh-101670: typo fix in PyImport_AppendInittab() (pythonGH-101672) pythongh-101196: Make isdir/isfile/exists faster on Windows (pythonGH-101324) pythongh-101614: Don't treat python3_d.dll as a Python DLL when checking extension modules for incompatibility (pythonGH-101615) pythongh-100933: Improve `check_element` helper in `test_xml_etree` (python#100934) pythonGH-101578: Normalize the current exception (pythonGH-101607) pythongh-47937: Note that Popen attributes are read-only (python#93070) ...
