Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-54738: Add argparse i18n howto #104562

Merged
merged 6 commits into from
Jul 23, 2023
Merged

gh-54738: Add argparse i18n howto #104562

merged 6 commits into from
Jul 23, 2023

Conversation

tomasr8
Copy link
Contributor

@tomasr8 tomasr8 commented May 16, 2023 •
edited by github-actions bot
Loading

Added documentation on how to localize the translatable strings in the argparse module.
Improvements welcome :)

📚 Documentation preview 📚: https://cpython-previews--104562.org.readthedocs.build/

@bedevere-bot bedevere-bot mentioned this pull request May 16, 2023
Closed
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 16, 2023
evildmp
evildmp suggested changes Jul 22, 2023
View reviewed changes
Doc/howto/argparse.rst Outdated Show resolved Hide resolved
Doc/howto/argparse.rst Outdated Show resolved Hide resolved
Doc/howto/argparse.rst Outdated Show resolved Hide resolved
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jul 22, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

evildmp
evildmp approved these changes Jul 22, 2023
View reviewed changes
Copy link
Contributor

@evildmp evildmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted: looks good to me as far as documentation good practice and style are concerned, but I am not an expert on the topic itself.

@ambv ambv merged commit dcd7acb into python:main Jul 23, 2023
15 checks passed
@ambv ambv added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jul 23, 2023
@miss-islington
Copy link
Contributor

Thanks @tomasr8 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @tomasr8 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2023
@tomasr8 @miss-islington
pythongh-54738: Add argparse i18n howto (pythonGH-104562)
8ee4650 
(cherry picked from commit dcd7acb)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
@bedevere-bot
Copy link

GH-107101 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 23, 2023
@bedevere-bot
Copy link

GH-107102 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2023
@tomasr8 @miss-islington
pythongh-54738: Add argparse i18n howto (pythonGH-104562)
b63558f 
(cherry picked from commit dcd7acb)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 23, 2023
@tomasr8 tomasr8 deleted the argparse-i18n branch July 23, 2023 09:14
ambv pushed a commit that referenced this pull request Jul 23, 2023
@miss-islington @tomasr8
[3.11] gh-54738: Add argparse i18n howto (GH-104562) (#107101)
65e40aa 
(cherry picked from commit dcd7acb)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
ambv pushed a commit that referenced this pull request Jul 23, 2023
@miss-islington @tomasr8
[3.12] gh-54738: Add argparse i18n howto (GH-104562) (#107102)
63ae7ed 
(cherry picked from commit dcd7acb)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 23, 2023
@tomasr8 @jtcave
pythongh-54738: Add argparse i18n howto (python#104562)
53cdf71
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
@tomasr8 @mementum
pythongh-54738: Add argparse i18n howto (python#104562)
c71f48e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evildmp evildmp evildmp approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomasr8 @miss-islington @bedevere-bot @evildmp @ambv