Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-104773: PEP 594: Remove the aifc module #104933

Merged
merged 3 commits into from
May 25, 2023
Merged

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 25, 2023

@vstinner
Copy link
Member Author

Please see the PEP 594 section about aifc:

A user disclosed that the post production film industry makes heavy use of the AIFC file format. The usage of the aifc module in closed source and internal software was unknown prior to the first posting of this PEP. This may be a compelling argument to keep the aifc module in the standard library. The file format is stable and the module does not require much maintenance. The strategic benefits for Python may outmatch the burden.

PEP 594 got accepted, so I understood that the Steering Council took these arguments in account and is fine with removing the aifc module from the Python stdlib.

test_aifc uses the audioop module which prevents the removal of the audioop module. If we want to keep the aifc module but remove audioop ,test_aifc should be rewritten without audioop.

@hugovk
Copy link
Member

hugovk commented May 25, 2023

Can we remove these test files as well?

./Lib/test/audiodata/pluck-ulaw.aifc
./Lib/test/audiodata/pluck-alaw.aifc
./Lib/test/Sine-1000Hz-300ms.aif

@vstinner
Copy link
Member Author

Someone else wrote a less complete PR: PR #104927.

* Remove .aifc and .aiff test files of Lib/test/audiodata/.
* Remove Lib/test/Sine-1000Hz-300ms.aif test file.
@vstinner
Copy link
Member Author

Can we remove these test files as well?

Right. I remove these test files and a few more.

@vstinner
Copy link
Member Author

With this change, test_wave becomes the last user of Lib/test/audiotests.py. I don't think that it's worth it to move the code into Lib/test/test_wave.py. I prefer to leave it as it is for now.

The two remaining AIFC test files are used by test_email:

Lib/test/test_email/data/sndhdr.aifc
Lib/test/test_email/data/sndhdr.aiff

@vstinner
Copy link
Member Author

The chunk module is related to AIFF: I wrote PR #104868 to remove it.

@vstinner
Copy link
Member Author

I added a What's New in Python 3.13 and Changelog entry.

@vstinner
Copy link
Member Author

A user disclosed that the post production film industry makes heavy use of the AIFC file format.

The VFX platform still uses Python 3.10 in 2023 ("CY2023"): https://vfxplatform.com/ Python will be upgraded to Python 3.11 next year ("CY2024 DRAFT").

@vstinner
Copy link
Member Author

See also issue #105096: wave: Deprecate getmark(), setmark() and getmarkers() methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants