Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-115254: Fix test_property with -00 mode #115255

Merged
merged 1 commit into from
Feb 10, 2024
Merged

gh-115254: Fix test_property with -00 mode #115255

merged 1 commit into from
Feb 10, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 10, 2024 •
edited by bedevere-app bot
Loading

It now passes with both modes.

@bedevere-app bedevere-app bot mentioned this pull request Feb 10, 2024
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Feb 10, 2024
@terryjreedy
Copy link
Member

Re-running 1 test for test_queue failure.

@sobolevn sobolevn added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Feb 10, 2024
@sobolevn sobolevn merged commit b70a68f into python:main Feb 10, 2024
37 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2024
@sobolevn @miss-islington
pythongh-115254: Fix test_property with -00 mode (pythonGH-115255)
b243496 
(cherry picked from commit b70a68f)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Feb 10, 2024

GH-115261 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Feb 10, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2024
@sobolevn @miss-islington
pythongh-115254: Fix test_property with -00 mode (pythonGH-115255)
2d6194b 
(cherry picked from commit b70a68f)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Feb 10, 2024

GH-115262 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 10, 2024
sobolevn added a commit that referenced this pull request Feb 11, 2024
@miss-islington @sobolevn
[3.11] gh-115254: Fix test_property with -00 mode (GH-115255) (#1…
7f2a19e 
…15262)

(cherry picked from commit b70a68f)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Feb 11, 2024
@miss-islington @sobolevn
[3.12] gh-115254: Fix test_property with -00 mode (GH-115255) (#1…
f036b35 
…15261)

gh-115254: Fix `test_property` with `-00` mode (GH-115255)
(cherry picked from commit b70a68f)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@sobolevn @fsc-eriker
pythongh-115254: Fix test_property with -00 mode (python#115255)
aa35422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @terryjreedy @serhiy-storchaka