Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test_capi.test_long #122113

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

serhiy-storchaka
Copy link
Member

Share common code for tests for PyLong_As*() functions.

Based on test changes in #120390. The same helper is used in tests for all signed and unsigned integer types. negative_value_error is now an exception class, not a boolean.

Share common code for tests for PyLong_As*() functions.

Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit 69f2dc5 into python:main Jul 22, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2024
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Jul 22, 2024

GH-122137 is a backport of this pull request to the 3.13 branch.

@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 69f2dc5c06e62b4a9eb4da8f0cd456cc09b998ed 3.12

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 22, 2024
@serhiy-storchaka
Copy link
Member Author

Thank you, Victor.

serhiy-storchaka added a commit that referenced this pull request Jul 23, 2024
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 23, 2024
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Jul 23, 2024

GH-122151 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jul 23, 2024
serhiy-storchaka added a commit that referenced this pull request Jul 23, 2024
Share common code for tests for PyLong_As*() functions.
(cherry picked from commit 69f2dc5)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants