Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-1635741: Port statistics module to multiphase initialization #19015

Merged
merged 2 commits into from
Mar 16, 2020
Merged

bpo-1635741: Port statistics module to multiphase initialization #19015

merged 2 commits into from
Mar 16, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Mar 15, 2020 •
edited by bedevere-bot
Loading

@corona10
Copy link
Member Author

@shihai1991 Can you please take a look?

shihai1991
shihai1991 approved these changes Mar 15, 2020
View reviewed changes
Copy link
Member

@shihai1991 shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked this source file(there have no _Py_IDENTIFIER or global vars), so this PR LGTM, thanks.

@corona10 corona10 requested a review from vstinner March 15, 2020 12:13
@shihai1991
Copy link
Member

let us ping experts @vstinner @encukou @ncoghlan

vstinner
vstinner reviewed Mar 16, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix the typo in the commit message and in the NEWS entry: it's the private _statistics module, not statistics :-)

Misc/NEWS.d/next/Core and Builtins/2020-03-15-20-51-15.bpo-1635741.iH0JND.rst Outdated Show resolved Hide resolved
@corona10 @vstinner
Update Misc/NEWS.d/next/Core and Builtins/2020-03-15-20-51-15.bpo-163…
10f1f0d 
…5741.iH0JND.rst

Co-Authored-By: Victor Stinner <vstinner@python.org>
@vstinner vstinner merged commit 356c878 into python:master Mar 16, 2020
@corona10 corona10 deleted the bpo-1635741-statistics branch March 16, 2020 15:17
@shihai1991 shihai1991 mentioned this pull request Jan 4, 2021
Merged
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@shihai1991 shihai1991 shihai1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot