Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-1635741: Enhance get_binascii_state() #19100

Closed
wants to merge 1 commit into from
Closed

bpo-1635741: Enhance get_binascii_state() #19100

wants to merge 1 commit into from

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Mar 21, 2020 •
edited by bedevere-bot
Loading

@shihai1991 shihai1991 changed the title bpo-1635741: Enhance get_binascii_module() bpo-1635741: Enhance get_binascii_state() Mar 22, 2020
corona10
corona10 reviewed Mar 24, 2020
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@corona10
Copy link
Member

corona10 commented Mar 24, 2020 •
edited
Loading

Looks like _Pickle_GetState needs same change on sperate PR..

cpython/Modules/_pickle.c

Line 183 in dffe4c0

_Pickle_GetState(PyObject *module)

@shihai1991
Copy link
Member Author

Looks like _Pickle_GetState needs same change on sperate PR..

cpython/Modules/_pickle.c

Line 183 in dffe4c0

_Pickle_GetState(PyObject *module)

I create this sperate change due to binascii extension module have been ported to pep-489.
IMO, other extension modules' get_xxx_state() can be done with porting operation.

@shihai1991
Copy link
Member Author

cc @vstinner Hi, victor. It's a enhancement operation of binascii's get_module_state()

@vstinner
Copy link
Member

I don't think that this change is worth it. In practice, I don't see why the state would be NULL. If it's the case, the code should crash anyway :-) Existing code which checks that the state is not NULL with an assertion is fine. But I don't think that this change is worth it.

@vstinner vstinner closed this Mar 26, 2020
@shihai1991
Copy link
Member Author

got it, thanks, victor :)

@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 left review comments

Assignees
No one assigned
Labels
awaiting review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shihai1991 @corona10 @vstinner @the-knights-who-say-ni @bedevere-bot