Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-1635741: Port resource extension module to multiphase initialization(PEP 489) #19252

Merged
merged 8 commits into from
Apr 2, 2020
Merged

bpo-1635741: Port resource extension module to multiphase initialization(PEP 489) #19252

merged 8 commits into from
Apr 2, 2020

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Mar 31, 2020 •
edited by bedevere-bot
Loading

corona10
corona10 reviewed Mar 31, 2020
View reviewed changes
Modules/resource.c Outdated Show resolved Hide resolved
corona10
corona10 reviewed Mar 31, 2020
View reviewed changes
Modules/resource.c Outdated Show resolved Hide resolved
@corona10
Copy link
Member

@shihai1991 Thanks for the contribution :) I left some comments for you

corona10
corona10 reviewed Mar 31, 2020
View reviewed changes
Modules/resource.c Outdated Show resolved Hide resolved
Modules/resource.c Outdated Show resolved Hide resolved
corona10
corona10 approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 requested a review from vstinner April 1, 2020 02:05
vstinner
vstinner requested changes Apr 1, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversion to multiphase init is correct, but I would like to take the opportunity of this refactoring to fix error handling.

Modules/resource.c Outdated Show resolved Hide resolved
Modules/resource.c Show resolved Hide resolved
Modules/resource.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vstinner
Copy link
Member

vstinner commented Apr 1, 2020

The macOS job failed because of https://bugs.python.org/issue40144

vstinner
vstinner reviewed Apr 1, 2020
View reviewed changes
Modules/resource.c Outdated Show resolved Hide resolved
Modules/resource.c Outdated Show resolved Hide resolved
@vstinner
Copy link
Member

vstinner commented Apr 2, 2020

The macOS job failed, see: https://bugs.python.org/issue40144

vstinner
vstinner reviewed Apr 2, 2020
View reviewed changes
Modules/resource.c Outdated Show resolved Hide resolved
Modules/resource.c Show resolved Hide resolved
Modules/resource.c Outdated Show resolved Hide resolved
vstinner
vstinner approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix coding style issues.

Modules/resource.c Outdated Show resolved Hide resolved
Modules/resource.c Outdated Show resolved Hide resolved
Modules/resource.c Outdated Show resolved Hide resolved
@vstinner
Copy link
Member

vstinner commented Apr 2, 2020

macOS is back to green, great ;-)

@vstinner vstinner merged commit 45f7008 into python:master Apr 2, 2020
@vstinner
Copy link
Member

vstinner commented Apr 2, 2020

Thanks. I completed the commit message to mention refleak fixes.

@shihai1991
Copy link
Member Author

Thanks. I completed the commit message to mention refleak fixes.

Got it, thanks.

@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@corona10 corona10 corona10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shihai1991 @corona10 @bedevere-bot @vstinner @the-knights-who-say-ni