bpo-41171: Added method "PyMetaType_FromSpec" to allow for specifying the metaclass for the type. #21238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe" to go with the "PyType" variants.
|
Paging @vstinner for review. |
vstinner
reviewed
Jun 30, 2020
Objects/typeobject.c
Outdated
| } | ||
|
|
||
| PyObject * | ||
| PyType_FromModuleAndSpec(PyObject *module, PyType_Spec *spec, PyObject *bases) | ||
| PyMetaType_FromModuleAndSpec(PyObject *module, PyTypeObject *meta_type, PyType_Spec *spec, PyObject *bases) |
There was a problem hiding this comment.
I propose the name PyMetaType_FromSpec and remove PyMetaType_FromSpecWithBases.
There was a problem hiding this comment.
So, you're suggesting renaming PyMetaType_FromSpecWithBases to just PyMetaType_FromSpec or just keeping the PyMetaType_FromSpec from above?
There was a problem hiding this comment.
Rename PyMetaType_FromModuleAndSpec (4 parameters) to PyMetaType_FromSpec. And so remove the other PyMetaType_FromSpec (2 parameters).
There was a problem hiding this comment.
Should I move the method out of "Py_LIMITED_API" then?
Added a note about 'PyMetaType_FromModuleAndSpec' in regards to 'tp_new'.
|
@vstinner I performed the change you requested. |
WildCard65
changed the title
|
Superseded by #93012 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41171