Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-1635741: Port faulthandler module to multiphase initialization #21294

Merged
merged 2 commits into from
Jul 3, 2020
Merged

bpo-1635741: Port faulthandler module to multiphase initialization #21294

merged 2 commits into from
Jul 3, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jul 3, 2020 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from vstinner July 3, 2020 14:34
corona10
corona10 commented Jul 3, 2020
View reviewed changes
Copy link
Member Author

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner @shihai1991 PTAL :)

vstinner
vstinner approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it seems like your PR introduces a compiler warning on the slots:

"initialization from incompatible pointer type [-Wincompatible-pointer-types]"

It may be good to fix it first.

Modules/faulthandler.c Outdated Show resolved Hide resolved
@corona10
Copy link
Member Author

corona10 commented Jul 3, 2020 •
edited
Loading

"initialization from incompatible pointer type [-Wincompatible-pointer-types]"

Yeah, it should be PyModuleDef_Slot, not PyType_Slot, it was my mistake.
I've fixed the PR, and after the test is passed, I will merge this PR

@vstinner
Copy link
Member

vstinner commented Jul 3, 2020

Yeah, it should be PyModuleDef_Slot, not PyType_Slot

Ooops :-)

@corona10 corona10 closed this Jul 3, 2020
@corona10 corona10 reopened this Jul 3, 2020
@corona10 corona10 mentioned this pull request Jul 3, 2020
Merged
@corona10 corona10 closed this Jul 3, 2020
@corona10 corona10 reopened this Jul 3, 2020
@corona10 corona10 merged commit c0b214b into python:master Jul 3, 2020
@corona10 corona10 deleted the bpo-1635741-fault branch July 3, 2020 16:36
@vstinner
Copy link
Member

vstinner commented Jul 3, 2020

Thanks for taking care of "my" little module :-)

arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@corona10 @arun-mani-j
bpo-1635741: Port faulthandler module to multiphase initialization (p…
bff6999 
…ythonGH-21294)
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot