Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39825: fix sysconfig.get_config_var('EXT_SUFFIX') on windows #22088

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Sep 4, 2020

Fixes sysconfig.get_config_var('EXT_SUFFIX') to the expected full platform_tag.extension format.

May influence downstream packages like wheel (@agronholm) which use this value,

https://bugs.python.org/issue39825

@mattip
Copy link
Contributor Author

mattip commented Sep 18, 2020

@agronholm @pitrou: any thoughts?

@pitrou
Copy link
Member

pitrou commented Sep 18, 2020

This looks fine to me. @zooba Any opinions?

@agronholm
Copy link
Contributor

Wheel does not seem to use this anyway.

@pitrou
Copy link
Member

pitrou commented Oct 12, 2020

@pfmoore Would you like to opine on this?

@mattip
Copy link
Contributor Author

mattip commented Oct 14, 2020

ping. Does this warrant a news item?

@zooba
Copy link
Member

zooba commented Oct 19, 2020

Looks fine to me, and yeah, let's give it a NEWS item (the NEWS should be the first place people search for "why did my thing just break", so try and describe it in terms that attract the sort of query).

Also, my GitHub notifications are an overflowing bottomless pit. Ping me on bpo to get my attention.

@zooba zooba added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes OS-windows labels Oct 19, 2020
@mattip
Copy link
Contributor Author

mattip commented Oct 20, 2020

NEWS fragment added. Since @zooba has no objections, could another core dev finish this off?

@zooba zooba merged commit c0afb7f into python:master Dec 7, 2020
@miss-islington
Copy link
Contributor

Thanks @mattip for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@zooba
Copy link
Member

zooba commented Dec 7, 2020

Thanks!

@bedevere-bot
Copy link

GH-23681 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Dec 7, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 7, 2020
… match distutils (pythonGH-22088)

(cherry picked from commit c0afb7f)

Co-authored-by: Matti Picus <matti.picus@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Dec 7, 2020
@bedevere-bot
Copy link

GH-23682 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 7, 2020
… match distutils (pythonGH-22088)

(cherry picked from commit c0afb7f)

Co-authored-by: Matti Picus <matti.picus@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Shared 3.x has failed when building commit c0afb7f.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/483/builds/513) and take a look at the build logs.
  4. Check if the failure is related to this commit (c0afb7f) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/483/builds/513

Failed tests:

  • test_sysconfig

Failed subtests:

  • test_EXT_SUFFIX_in_vars - test.test_sysconfig.TestSysConfig

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

405 tests OK.

10 slowest tests:

  • test_smtpnet: 6 min 8 sec
  • test_nntplib: 3 min 49 sec
  • test_concurrent_futures: 3 min 36 sec
  • test_tokenize: 2 min 14 sec
  • test_multiprocessing_spawn: 2 min 8 sec
  • test_urllib2: 2 min 1 sec
  • test_unparse: 2 min
  • test_multiprocessing_forkserver: 1 min 46 sec
  • test_subprocess: 1 min 30 sec
  • test_asyncio: 1 min 14 sec

1 test failed:
test_sysconfig

19 tests skipped:
test_dbm_gnu test_devpoll test_epoll test_idle test_ioctl
test_msilib test_ossaudiodev test_spwd test_startfile test_tcl
test_tix test_tk test_ttk_guionly test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_sysconfig

Total duration: 13 min 50 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/test/test_sysconfig.py", line 368, in test_EXT_SUFFIX_in_vars
    self.assertEqual(vars['EXT_SUFFIX'], _imp.extension_suffixes()[0])
AssertionError: '.so' != '.cpython-310d.so'
- .so
+ .cpython-310d.so

miss-islington added a commit that referenced this pull request Dec 7, 2020
… match distutils (GH-22088)

(cherry picked from commit c0afb7f)

Co-authored-by: Matti Picus <matti.picus@gmail.com>
miss-islington added a commit that referenced this pull request Dec 7, 2020
… match distutils (GH-22088)

(cherry picked from commit c0afb7f)

Co-authored-by: Matti Picus <matti.picus@gmail.com>
@mattip
Copy link
Contributor Author

mattip commented Dec 7, 2020

Did I miss something? The FREEBSD buildbot is failing with

======================================================================
FAIL: test_EXT_SUFFIX_in_vars (test.test_sysconfig.TestSysConfig)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/test/test_sysconfig.py", line 368, in test_EXT_SUFFIX_in_vars
    self.assertEqual(vars['EXT_SUFFIX'], _imp.extension_suffixes()[0])
AssertionError: '.so' != '.cpython-310d.so'
- .so
+ .cpython-310d.so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants