Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41732: add iterator to memoryview #22119

Merged
merged 3 commits into from Sep 8, 2020
Merged

bpo-41732: add iterator to memoryview #22119

merged 3 commits into from Sep 8, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 6, 2020 •
edited by bedevere-bot
Loading

Custom iterator to memoryview - performance improvement while iterating over memoryview objs. bpo

https://bugs.python.org/issue41732

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@dxflores

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@ghost ghost mentioned this pull request Sep 6, 2020
Closed
@corona10
Copy link
Member

corona10 commented Sep 6, 2020

@dxflores Please sign up for the CLA first! :)

I add the reviewers including @gvanrossum since this PR looks like from guido's mentoring :)

@ghost
Copy link
Author

ghost commented Sep 6, 2020

@corona10 I did before. I guess it's not showing up yet but I did sign it.

@gvanrossum
Copy link
Member

gvanrossum commented Sep 6, 2020 via email •
edited
Loading

@ghost
Copy link
Author

ghost commented Sep 6, 2020

Guido, I did sign it today (and I changed my username yesterday). I can send you the confirmation via e-mail if you would like.

@gvanrossum
Copy link
Member

No, it just takes time (there's a human in the loop). In a day, try the "check yourself" instructions from the comment about it. In the meantime you can also add a News item (instructions will be revealed when you click "Details" for the failed test).

gvanrossum
gvanrossum approved these changes Sep 6, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Diogo is my mentee, I've reviewed the code extensively.)

@ghost
Copy link
Author

ghost commented Sep 6, 2020

Thank you Guido, I will check again tomorrow. In the meantime I have added the News item.

@corona10
Update Misc/NEWS.d/next/Library/2020-09-06-20-27-10.bpo-41732.1SKv26.rst
c3dd9cd 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@corona10 corona10 merged commit b0ac5d7 into python:master Sep 8, 2020
@gvanrossum
Copy link
Member

Still curious why the CLA didn’t appear signed.

@ghost
Copy link
Author

ghost commented Sep 8, 2020

Could it have something to do with the fact that I logged in to BPO directly with my e-mail instead of with my GitHub account?

@gvanrossum
Copy link
Member

Probably just a human delay due to Labor Day (a US holiday). It's green now!

@ghost ghost deleted the memoryview_patch-41732 branch September 9, 2020 19:54
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 10, 2020
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_1635741_1
00b300c 
* origin/master: (1373 commits)
  bpo-1635741: Port mashal module to multi-phase init (python#22149)
  bpo-1635741: Port _string module to multi-phase init (pythonGH-22148)
  bpo-1635741: Convert _sha256 types to heap types (pythonGH-22134)
  bpo-1635741: Port the termios to multi-phase init (PEP 489) (pythonGH-22139)
  bpo-41732: add iterator to memoryview (pythonGH-22119)
  bpo-40744: Drop support for SQLite pre 3.7.3 (pythonGH-20909)
  bpo-41316: Make tarfile follow specs for FNAME (pythonGH-21511)
  bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (pythonGH-22092)
  bpo-1635741 port _curses_panel to multi-phase init (PEP 489) (pythonGH-21986)
  bpo-1635741: Port _overlapped module to multi-phase init (pythonGH-22051)
  bpo-1635741: Port _opcode module to multi-phase init (PEP 489) (pythonGH-22050)
  bpo-1635741 port zlib module to multi-phase init (pythonGH-21995)
  [doc] Add link to Generic in typing (pythonGH-22125)
  bpo-41513: Expand comments and add references for a better understanding (pythonGH-22123)
  bpo-1635741: Port _sha1, _sha512, _md5 to multiphase init (pythonGH-21818)
  closes bpo-41723: Fix an error in the py_compile documentation. (pythonGH-22110)
  [doc] Fix padding in some typing definitions (pythonGH-22114)
  Fix documented Python version for venv --upgrade-deps (pythonGH-22113)
  bpo-40318: Migrate to SQLite3 trace v2 API (pythonGH-19581)
  bpo-41687: Fix sendfile implementation to work with Solaris (python#22040)
  ...
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
bpo-41732: add iterator to memoryview (pythonGH-22119)
3030f56
@DimitrisJim DimitrisJim mentioned this pull request Nov 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@the-knights-who-say-ni @corona10 @gvanrossum @bedevere-bot