bpo-1635741: testbuffer heap types #22131
Conversation
|
@vstinner @shihai1991 @corona10 I tried to take the conversions of just the heap types from #22003 in this PR. The tests are crashing here starting from the second commit (the staticarray conversion to a heap type did not cause any problems). I'm putting it up for review in case any of you could help me spot the problem. multi-phase init, moving more globals to the module state, and any PEP7 style changes are going to come in a follow-up once I can identify the problems with this change. |
| @@ -2734,7 +2721,9 @@ staticarray_init(PyObject *self, PyObject *args, PyObject *kwds) | |||
| static void | |||
| staticarray_dealloc(StaticArrayObject *self) | |||
| { | |||
| PyTypeObject *tp = Py_TYPE(self); | |||
| PyObject_Del(self); | |||
There was a problem hiding this comment.
See compiler warnings at https://github.com/python/cpython/pull/22131/files , like:
‘ndarray_as_buffer’ defined but not used [-Wunused-variable]
|
This is a test module. The PR removes a test that explicitly tests static types at the request of @scoder . It is not necessary to make changes to this module. |
https://bugs.python.org/issue1635741