Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-1635741 port cmath to multi-phase init (pep 489) #22165

Merged
merged 3 commits into from
Sep 10, 2020
Merged

bpo-1635741 port cmath to multi-phase init (pep 489) #22165

merged 3 commits into from
Sep 10, 2020

Conversation

koubaa
Copy link
Contributor

@koubaa koubaa commented Sep 9, 2020 •
edited by bedevere-bot
Loading

@koubaa
Copy link
Contributor Author

koubaa commented Sep 9, 2020

@vstinner @shihai1991 @corona10 please review

vstinner
vstinner reviewed Sep 9, 2020
View reviewed changes
Modules/cmathmodule.c Outdated Show resolved Hide resolved
Modules/cmathmodule.c Outdated Show resolved Hide resolved
vstinner
vstinner approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner merged commit f76d894 into python:master Sep 10, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@koubaa
bpo-1635741: Port cmath to multi-phase init (PEP 489) (pythonGH-22165)
395142d
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koubaa @vstinner @the-knights-who-say-ni @bedevere-bot