Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42029: Remove IRIX code #23023

Merged
merged 1 commit into from
Oct 29, 2020
Merged

bpo-42029: Remove IRIX code #23023

merged 1 commit into from
Oct 29, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 29, 2020

IRIX code was slowy removed in Python 2.4 (--with-sgi-dl), Python 3.3
(Irix threads), and Python 3.7.

https://bugs.python.org/issue42029

IRIX code was slowy removed in Python 2.4 (--with-sgi-dl), Python 3.3
(Irix threads), and Python 3.7.
@vstinner
Copy link
Member Author

cc @kadler

@vstinner vstinner added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Oct 29, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit b3d5b3d 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 29, 2020
@vstinner
Copy link
Member Author

I'm not confident in my resource.getpagesize() change, so I test my PR on buildbots.

@vstinner vstinner merged commit 5776663 into python:master Oct 29, 2020
@vstinner vstinner deleted the remove_irix_code branch October 29, 2020 14:16
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 3.x has failed when building commit 5776663.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/509/builds/260) and take a look at the build logs.
  4. Check if the failure is related to this commit (5776663) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/509/builds/260

Failed tests:

  • test_os
  • test_multiprocessing_fork

Failed subtests:

  • test_utime_current_old - test.test_os.UtimeTests
  • test_utime_current - test.test_os.UtimeTests

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/test_os.py", line 762, in test_utime_current_old
    self._test_utime_current(set_time)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/test_os.py", line 749, in _test_utime_current
    self.assertAlmostEqual(st.st_mtime, current,
AssertionError: 1603981504.2480948 != 1603981504.3209374 within 0.05 delta (0.07284259796142578 difference) : st_time=1603981504.2480948, current=1603981504.3209374, dt=-0.07284259796142578


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/test_os.py", line 756, in test_utime_current
    self._test_utime_current(set_time)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z/build/Lib/test/test_os.py", line 749, in _test_utime_current
    self.assertAlmostEqual(st.st_mtime, current,
AssertionError: 1603981504.2480948 != 1603981504.318087 within 0.05 delta (0.0699923038482666 difference) : st_time=1603981504.2480948, current=1603981504.318087, dt=-0.0699923038482666

shihai1991 added a commit to shihai1991/cpython that referenced this pull request Oct 29, 2020
…lots1

* origin/master: (365 commits)
  bpo-42029: Remove IRIX code (pythonGH-23023)
  bpo-42143: Ensure PyFunction_NewWithQualName() can't fail after creating the func object (pythonGH-22953)
  bpo-34204: Use pickle.DEFAULT_PROTOCOL in shelve (pythonGH-19639)
  bpo-41805: Documentation for PEP 585 (pythonGH-22615)
  bpo-42161: Micro-optimize _collections._count_elements() (pythonGH-23008)
  bpo-42161: Remove private _PyLong_Zero and _PyLong_One (pythonGH-23003)
  bpo-42099: Fix reference to ob_type in unionobject.c and ceval (pythonGH-22829)
  bpo-41659: Disallow curly brace directly after primary (pythonGH-22996)
  bpo-6761: Enhance __call__ documentation (pythonGH-7987)
  bpo-42161: Modules/ uses _PyLong_GetZero() and _PyLong_GetOne() (pythonGH-22998)
  bpo-41474, Makefile: Add dependency on cpython/frameobject.h (pythonGH-22999)
  bpo-42157: Rename unicodedata.ucnhash_CAPI (pythonGH-22994)
  bpo-42161: Use _PyLong_GetZero() and _PyLong_GetOne() (pythonGH-22995)
  bpo-30681: Support invalid date format or value in email Date header (pythonGH-22090)
  bpo-42161: Add _PyLong_GetZero() and _PyLong_GetOne() (pythonGH-22993)
  bpo-42123: Run the parser two times and only enable invalid rules on the second run (pythonGH-22111)
  bpo-42157: Convert unicodedata.UCD to heap type (pythonGH-22991)
  bpo-42157: unicodedata avoids references to UCD_Type (pythonGH-22990)
  bpo-39101: Fixes BaseException hang in IsolatedAsyncioTestCase. (pythonGH-22654)
  bpo-1635741: _PyUnicode_Name_CAPI moves to internal C API (pythonGH-22713)
  ...
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
IRIX code was slowy removed in Python 2.4 (--with-sgi-dl), Python 3.3
(Irix threads), and Python 3.7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants