Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43795: Add a test for Stable ABI symbol availability using ctypes #26354

Merged
merged 7 commits into from
Oct 22, 2021
Merged

bpo-43795: Add a test for Stable ABI symbol availability using ctypes #26354

merged 7 commits into from
Oct 22, 2021

Conversation

encukou
Copy link
Member

@encukou encukou commented May 25, 2021 •
edited by bedevere-bot
Loading

This is a cross-platform check that the symbols are actually
exported in the ABI, not e.g. hidden in a macro.

https://bugs.python.org/issue43795

@encukou
Add a test for Stable ABI symbol availability using ctypes
12e08ff 
This is a cross-platform check that the symbols are actually
exported in the ABI, not e.g. hidden in a macro.
@encukou encukou added the needs backport to 3.10 only security fixes label May 25, 2021
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 1, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 4278bc5 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 1, 2021
@encukou
Copy link
Member Author

encukou commented Jun 1, 2021

Aha, I didn't realize ctypes is an optional module. Thanks, Gentoo Installed with X PR buildbot!

@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 1, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 39446ab 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 1, 2021
@encukou
Copy link
Member Author

encukou commented Jun 3, 2021

So, still not quite there:

  • AMD64 Arch Linux TraceRefs PR reports missing symbols PyModule_Create2 and PyModule_FromDefAndSpec2!
  • s390x Fedora Refleaks PR and x86 Gentoo Installed with X PR unrelated (test_asyncio timeout, test_idle failure)

@vstinner
Copy link
Member

vstinner commented Jun 3, 2021

test_asyncio timeout

I guess that it's https://bugs.python.org/issue44112 Yesterday, I increased the buildbot timeout from 3 hours to 4 hours to be able to debug this issue.

test_idle failure

I should be fixed: https://bugs.python.org/issue44282

@vstinner
Copy link
Member

vstinner commented Jun 3, 2021

AMD64 Arch Linux TraceRefs PR reports missing symbols PyModule_Create2 and PyModule_FromDefAndSpec2!

I guess that it's a similar issue than https://bugs.python.org/issue44133

We should try to link the Python binary from objects files (.o) rather than using the libpython static library.

@github-actions
Copy link

github-actions bot commented Jul 4, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 4, 2021
@encukou
Merge main branch
0cf75d2
@encukou
Regenerate the test file
b5f7f0f
@encukou
Skip the test for PyModule_Create2 & PyModule_FromDefAndSpec2
a0c765a 
These aren't exported on some platforms.
All the others should still be tested, though, to make sure
they don't disappear.
@encukou encukou added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed stale Stale PR or inactive for long period of time. labels Oct 21, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit a0c765a 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 21, 2021
@encukou encukou merged commit 276468d into python:main Oct 22, 2021
@miss-islington
Copy link
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@encukou encukou deleted the pep652-ctypes2 branch October 22, 2021 08:12
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 22, 2021
@bedevere-bot
Copy link

GH-29148 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2021
@encukou @miss-islington
bpo-43795: Add a test for Stable ABI symbol availability using ctypes (…
a1991a8 
…pythonGH-26354)

This is a cross-platform check that the symbols are actually
exported in the ABI, not e.g. hidden in a macro.

Caveat: PyModule_Create2 & PyModule_FromDefAndSpec2 are skipped.

These aren't exported on some of our buildbots. This is a bug
(bpo-44133). This test now makes sure all the others don't regress.
(cherry picked from commit 276468d)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@encukou encukou mentioned this pull request Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@encukou @bedevere-bot @vstinner @miss-islington @erlend-aasland @the-knights-who-say-ni