Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45743: Move __APPLE_USE_RFC_3542 into socketmodule.c (GH-29456) #29456

Merged
merged 1 commit into from
Nov 8, 2021
Merged

bpo-45743: Move __APPLE_USE_RFC_3542 into socketmodule.c (GH-29456) #29456

merged 1 commit into from
Nov 8, 2021

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 7, 2021 •
edited by bedevere-bot
Loading

@tiran
bpo-45743: Move __APPLE_USE_RFC_3542 into socketmodule.c
f8e8a2b 
Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran added the skip news label Nov 7, 2021
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Nov 8, 2021 •
edited
Loading

IIRC, the correct preprocessor check for macOS is: #if defined(__APPLE__) && defined(__MACH__).

cc. @ronaldoussoren

ronaldoussoren
ronaldoussoren approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@erland-aasland: Just using #ifdef APPLE is fine, we haven't supported classic MacOS in a long time.

@tiran tiran changed the title bpo-45743: Move __APPLE_USE_RFC_3542 into socketmodule.c bpo-45743: Move __APPLE_USE_RFC_3542 into socketmodule.c (GH-29456) Nov 8, 2021
@tiran tiran merged commit 24af9a4 into python:main Nov 8, 2021
@tiran tiran deleted the bpo-45743-socket branch November 8, 2021 11:48
@tiran
Copy link
Member Author

tiran commented Nov 8, 2021

Thanks @ronaldoussoren and @erlend-aasland

remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran @remykarem
bpo-45743: Move __APPLE_USE_RFC_3542 into socketmodule.c (pythonGH-29456
b675a1e 
)
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
@tiran @remykarem
bpo-45743: Move __APPLE_USE_RFC_3542 into socketmodule.c (pythonGH-29456
20bde6e 
)
@tiran tiran mentioned this pull request Jul 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldoussoren ronaldoussoren ronaldoussoren approved these changes

@ned-deily ned-deily Awaiting requested review from ned-deily

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiran @erlend-aasland @ronaldoussoren @the-knights-who-say-ni @bedevere-bot