bpo-45847: Port nis module to PY_STDLIB_MOD (GH-29699) #29699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @tiran for commit 3043b762c9cbcb0500de5d9e19cb4139e1457d40 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
tiran
changed the title
tiran
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @tiran for commit c6c687160b4ad830a55235581e6515f36ffe27cd 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Signed-off-by: Christian Heimes <christian@python.org>
tiran
commented
Nov 22, 2021
| @@ -40,7 +40,7 @@ | |||
| @MODULE__QUEUE_TRUE@_queue _queuemodule.c | |||
| @MODULE__RANDOM_TRUE@_random _randommodule.c | |||
| @MODULE__TYPING_TRUE@_typing _typingmodule.c | |||
| @MODULE__XXSUBINTERPRETERS_TRUE@_xxsubinterpreters __xxsubinterpretersmodule.c | |||
| @MODULE__XXSUBINTERPRETERS_TRUE@_xxsubinterpreters _xxsubinterpretersmodule.c | |||
There was a problem hiding this comment.
@erlend-aasland I'm sneaking in this typo fix, too.
erlend-aasland
requested changes
Nov 22, 2021
| @@ -6166,6 +6188,9 @@ PY_STDLIB_MOD([_sha3], [test "$with_builtin_sha3" = yes]) | |||
| PY_STDLIB_MOD([_blake2], [test "$with_builtin_blake2" = yes]) | |||
|
|
|||
| PY_STDLIB_MOD([_decimal], [], [], [$LIBMPDEC_CFLAGS], [$LIBMPDEC_LDFLAGS]) | |||
| PY_STDLIB_MOD([nis], | |||
| [], [test "$have_nis" = yes -a "$ac_cv_header_rpc_rpc_h" = yes], | |||
There was a problem hiding this comment.
AFAICS, header check for rpc/rpc.h is missing.
There was a problem hiding this comment.
It's right there:
AS_VAR_IF([have_nis], [yes], [
WITH_SAVE_ENV([
CPPFLAGS="$LIBNSL_CFLAGS $CFLAGS"
AC_CHECK_HEADERS([rpc/rpc.h])
])
])
erlend-aasland
approved these changes
Nov 22, 2021
tiran
changed the title
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue45847