Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.9] bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" #30566

Closed
wants to merge 3 commits into from
Closed

[3.9] bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" #30566

wants to merge 3 commits into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 12, 2022 •
edited by bedevere-bot
Loading

This reverts commit 7247407.

Fix a random crash involving subinterpreters on Windows. Revert the
change which made the gc module state per interpreter: the gc module
state is shared again by all interpreters.

https://bugs.python.org/issue36854

@vstinner
bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterprete…
2096c10 
…rState (GH-17287)"

This reverts commit 7247407.

Fix a random crash involving subinterpreters on Windows. Revert the
change which made the gc module state per interpreter: the gc module
state is shared again by all interpreters.
@vstinner vstinner changed the title [3.9] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" bpo-46070: [3.9] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" Jan 12, 2022
ericsnowcurrently
ericsnowcurrently approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner changed the title bpo-46070: [3.9] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" [3.9] bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" Jan 13, 2022
@vstinner
Copy link
Member Author

Without this PR, I can crash Python in a reliable way using this method: https://bugs.python.org/issue46070#msg410447

With this PR, I can no longer reproducer the crash: Python is fixed.

@brettcannon brettcannon removed their request for review January 13, 2022 01:02
@vstinner
Copy link
Member Author

I wrote a simpler fix: GH-30577.

@vstinner vstinner closed this Jan 13, 2022
@vstinner vstinner deleted the revert_gc39 branch January 13, 2022 18:31
@graysky graysky mannequin mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@encukou encukou Awaiting requested review from encukou encukou is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot