gh-95349: Hide a Distutils Warning Filter for test_check_c_globals #95837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
approved these changes
Aug 9, 2022
|
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 9, 2022
…als (pythonGH-95837) Under certain build conditions, test_check_c_globals fails. This fix takes the same approach as we took for pythongh-84236 (via pythongh-20095). We'll be removing use of distutils in the c-analyzer at some point. Until then we'll hide the warning filter. (cherry picked from commit 3ff6d9a) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
|
GH-95843 is a backport of this pull request to the 3.11 branch. |
ambv
pushed a commit
that referenced
this pull request
Aug 10, 2022
…H-95837) (GH-95843) Under certain build conditions, test_check_c_globals fails. This fix takes the same approach as we took for gh-84236 (via gh-20095). We'll be removing use of distutils in the c-analyzer at some point. Until then we'll hide the warning filter. (cherry picked from commit 3ff6d9a) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
|
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Sorry, this applies to 3.10 as well, so one more backport |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 10, 2022
…als (pythonGH-95837) Under certain build conditions, test_check_c_globals fails. This fix takes the same approach as we took for pythongh-84236 (via pythongh-20095). We'll be removing use of distutils in the c-analyzer at some point. Until then we'll hide the warning filter. (cherry picked from commit 3ff6d9a) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
|
GH-95864 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Aug 11, 2022
…H-95837) Under certain build conditions, test_check_c_globals fails. This fix takes the same approach as we took for gh-84236 (via gh-20095). We'll be removing use of distutils in the c-analyzer at some point. Until then we'll hide the warning filter. (cherry picked from commit 3ff6d9a) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Aug 11, 2022
…als (pythonGH-95837) Under certain build conditions, test_check_c_globals fails. This fix takes the same approach as we took for pythongh-84236 (via pythongh-20095). We'll be removing use of distutils in the c-analyzer at some point. Until then we'll hide the warning filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain build conditions, test_check_c_globals fails. This fix takes the same approach as we took for gh-84236 (via gh-20095). We'll be removing use of distutils in the c-analyzer at some point. Until then we'll hide the warning filter.
Automerge-Triggered-By: GH:ericsnowcurrently