Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-90699: Remove _Py_IDENTIFIER usage from _asyncio module #99010

Merged
merged 1 commit into from
Nov 2, 2022
Merged

GH-90699: Remove _Py_IDENTIFIER usage from _asyncio module #99010

merged 1 commit into from
Nov 2, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Nov 2, 2022 •
edited by miss-islington
Loading

Automerge-Triggered-By: GH:ericsnowcurrently

@bedevere-bot bedevere-bot mentioned this pull request Nov 2, 2022
Closed
ericsnowcurrently
ericsnowcurrently approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JelleZijlstra JelleZijlstra merged commit 18fc232 into python:main Nov 2, 2022
@kumaraditya303 kumaraditya303 deleted the asyncio branch November 2, 2022 17:17
gvanrossum
gvanrossum reviewed Nov 2, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I guess this makes it easier to convert this code to two-phase init?

@ericsnowcurrently
Copy link
Member

Yep. Also, we're trying to get rid of _Py_IDENTIFIER().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum left review comments

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kumaraditya303 @ericsnowcurrently @gvanrossum @JelleZijlstra @bedevere-bot