Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily tests failed on Fri Jun 07 2024 #12107

Closed
github-actions bot opened this issue Jun 7, 2024 · 4 comments
Closed

Daily tests failed on Fri Jun 07 2024 #12107

github-actions bot opened this issue Jun 7, 2024 · 4 comments
Labels
help wanted An actionable problem of low to medium complexity where a PR would be very welcome

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Runs listed here: https://github.com/python/typeshed/actions/workflows/daily.yml

@github-actions github-actions bot added the help wanted An actionable problem of low to medium complexity where a PR would be very welcome label Jun 7, 2024
@srittau
Copy link
Collaborator

srittau commented Jun 7, 2024

error: jsonschema._format.is_css21_color is not present at runtime
Stub: in file /home/runner/work/typeshed/typeshed/stubs/jsonschema/jsonschema/_format.pyi:43
def (instance: builtins.object) -> builtins.bool
Runtime:
MISSING

error: jsonschema._format.is_css_color_code is not present at runtime
Stub: in file /home/runner/work/typeshed/typeshed/stubs/jsonschema/jsonschema/_format.pyi:42
def (instance: builtins.object) -> builtins.bool
Runtime:
MISSING

@AlexWaygood
Copy link
Member

It looks like the functions in question exist if ImportError is not raised in this block here, but do not exist if ImportError is raised in the block: https://github.com/python-jsonschema/jsonschema/blob/0024b584c6b6f332f0f5fa5452488901b73328f9/jsonschema/_format.py#L415-L429

The block has two import statements in it: it tries to import webcolors, and it tries to import a specific constant from webcolors. webcolors cut a new release on June 6: https://pypi.org/project/webcolors/. The new release gets rid of one of the constants that the block is trying to import, so now ImportError is always raised in that block at runtime, meaning that the relevant functions in jsonschema are never defined.

@AlexWaygood
Copy link
Member

I think the proper course of action here is:

  1. Pin webcolors to an older version in our CI to fix stubtest
  2. File an issue at jsonschema to let them know that this block now always raises ImportError.

I don't think we should change our stubs until jsonschema and webcolors have sorted this out between themselves.

@AlexWaygood
Copy link
Member

I opened python-jsonschema/jsonschema#1268, so I think we've done all we need to on this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted An actionable problem of low to medium complexity where a PR would be very welcome
Projects
None yet
Development

No branches or pull requests

2 participants