Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update NCCL==2.18.3 #1526

Closed
wants to merge 22 commits into from
Closed

Conversation

ptrblck
Copy link
Collaborator

@ptrblck ptrblck commented Sep 8, 2023

Move NCCL to 2.18.3 as it was used in pytorch:main before the most recent update to 2.18.5.
Note that NCCL did not release 2.18.5 binaries yet, so we should stick to the latest 2.18.3 version in torch==2.1.0.

CC @atalman

atalman and others added 22 commits August 29, 2023 12:14
* Aarch64 fix overrdie passing from CI to build

* Aarch64 fix overrdie passing from CI to build

* Aarch64 fix overrdie passing from CI to build
We will need the stable torchmetrics wheel in the S3 index, since torchrec depends on it. This is similar to how pytorch depends on numpy, etc. and these binaries need to be hosted in our index when uses try to pip install from download.pytorch.org.
@ptrblck
Copy link
Collaborator Author

ptrblck commented Sep 8, 2023

@malfet @atalman

pytorch/pytorch updated NCCL in pytorch/pytorch#107883 which also landed in the 2.1.0 release candidates. E.g.: https://github.com/pytorch/pytorch/tree/v2.1.0-rc3/third_party

Since the 2.18.5 binaries are not released yet we would diverge in torch==2.1.0 between the binaries and a source build.
Should we revert pytorch/pytorch#107883 in v2.1.0-rc3?

@atalman atalman changed the base branch from main to release/2.1 September 8, 2023 21:59
@ptrblck
Copy link
Collaborator Author

ptrblck commented Sep 8, 2023

Closing in favor of: #1527

@ptrblck ptrblck closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants