Vsifile - more fixes : bugs and tar support + file open #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and scanItemsInBrowser
…gz files and large .zip files until requested
… ; fix gdal sublayer names
|
This is basically pull request 163 from recent master If you want a netcdf and/or hdf4 file to test against, I can provide a link or send one |
|
patch applied in master |
|
thanks Jef! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to fix to issues but also enhances both zip and tar file support
3c132f2 remove Passthru option and change storage of options scanZipInBrowser and scanItemsInBrowser
The Passthru option is confusing and unnecessary - because zip reading is no longer dependent on quazip
7ed8415 add support for .tar/.tgz files and relevant tests ; delay scan of .tgz files and large .zip files until requested
I found that opening a directory with large .zip files was really slow (like minutes), so this patch does not scan for contents of large zip files (>10 items), and as a bonus I added .tar and .tgz support. For performance reasons .tgz files are never scanned until requested (i.e. when the item is opened by the user).
9915c5a add zip item layer dialog to open .zip and .tar files with many files ; fix gdal sublayer names
This adds support for opening files from the regular file Open dialogs. A popup appears, similar to the Choose OGR/GDAL Layers dialog.
I also shortened the item names of gdal files with subdatasets, which could be very long (e.g. NETCDF:"longfilename.nc":variable) and were truncated (e.g. NETCDF:"longfilename.nc), because of changes in layer name for bug #5636
171799f user layerName() when adding raster from browser (#5636)
somehow this didn't make it up to here... re-applied