Do not register QgsFilterLineEdit's child widgets as QgsOptionsDialogHighlightWidget #40480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HighlightWidget The clear value button might be deleted. This allows QgsFilterLineEdit, QgsSpinBox and QgsDoubleSpinbox usage in options.
nyalldawson
approved these changes
Dec 7, 2020
|
Good catch! |
|
Backported as a0306ef |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QgsSpinBoxandQgsDoubleSpinBoxuse aQgsFilterLineEditthat has a button to clear its contents. This button is deletedonce it is pressed and re-created when the spinbox value has changed, so if it is registered for highlighting and the button is pressed QGIS crashes when trying to highlight search results!
This allows proper usage of
QgsSpinboxandQgsDoubleSpinBoxin options, as well asQgsFilterLineEdit(not used yet used in options)Fixes #40111