Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[symbology] fix duplicate layers in symbol levels dialog #5041

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Aug 18, 2017

Description

This PR fixes a regression following commit a899963, whereas symbol layers are shown twice in the symbol levels dialog.

It fixes part of the issue filed here: https://issues.qgis.org/issues/16996 -- however, it still doesn't address the bigger issue, namely: symbol levels are broken, always set to 0!

@wonder-sk , I suspect the regression might be linked to your legend rework / cleanup. Could you have a look at this PR, as well as the bigger issue raised? Cheers.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@nirvn
Copy link
Contributor Author

nirvn commented Sep 5, 2017

@wonder-sk , I'm going to merge this now. Hope you can take a look at the more serious regression in the near future (i.e. symbol lelvels not working for rule-based symbology).

@nirvn nirvn merged commit 72462ae into qgis:master Sep 5, 2017
@nirvn nirvn deleted the rules_dup_fix branch February 26, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant