-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processing] add area report to raster layer unique values algorithm #5334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would "Raster Layer Statistics" be a better name here?
@@ -0,0 +1,29 @@ | |||
<html><head><meta http-equiv="Content-Type" content="text/html;charset=utf-8"/></head><body> | |||
<p>Analyzed file: /home/webmaster/dev/cpp/QGIS/python/plugins/processing/tests/testdata/raster.tif (band 1)</p> | |||
<p>Extent: 270736.0673250681720674,4458888.9563983473926783 : 270899.8544675338780507,4459029.5745217483490705</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be handy to export all these extra properties as outputs from the alg too, so they could be used in later model steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyalldawson , you tink so? Which one(s) would you like to be exposed? TOTAL_PIXEL_COUNT, and NODATA_COUNT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expose ALL the things!
Extent, projection (as authid), all the numeric values
They could all be potentially reused later in a model
@nyalldawson , "raster layer statistics" is already taken by an algorithm that provides basic stats for a given raster layer band. Using report is a nod to GRASS' r.report module, which provides unique value count & area values too. |
@nyalldawson , however, I should probably add statistic as a keyword for this alg. |
1f42856
to
9bfba0b
Compare
@nyalldawson , comments addressed in the updated commit. Thanks. |
Looks good! |
Description
This PR adds area alongside pixel count to the raster unique values
countreport algorithm.As indicated above, I've renamed the algorithm since it now does more than counting pixels.
Checklist
fixes #11111
in the commit message next to the description[FEATURE]
in the commit message[needs-docs]
in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.sh
script before each commit