Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to pyproject.toml? (PEP 517, 518 support) #1109

Closed
nullableVoidPtr opened this issue Mar 9, 2022 · 2 comments
Closed

Migration to pyproject.toml? (PEP 517, 518 support) #1109

nullableVoidPtr opened this issue Mar 9, 2022 · 2 comments

Comments

@nullableVoidPtr
Copy link
Contributor

nullableVoidPtr commented Mar 9, 2022

I can do this in a PR, but I wanted to ask if there were any objections before I get started on this.

As of recently, setup.py has been considered deprecated in favor of a build-system independent format.
Seeing as qiling only uses setuptools anyways, the plan to migrate the package to PEP 518 is to specify only setuptools in the pyproject.toml file, alongside dependencies, license, and other metadata.
This setup would either shrink or remove setup.py entirely; setuptools itself does not support editable installs without a setup.py, but that has a workaround in pip, although this mandates a minimum pip version of 21.3.

@elicn
Copy link
Member

elicn commented Mar 9, 2022

Keeping up to date with the standard is always good, but we have leave some room for slower user adoption (meaning not moving forward too fast). Specifically, this project made a decision to move to Python 3.8 just recently, so we have to make sure this change doesn't break anything.

That being said, I think this is a great idea.

@nullableVoidPtr nullableVoidPtr mentioned this issue Mar 9, 2022
15 tasks
@xwings
Copy link
Member

xwings commented Oct 6, 2022

Close for now.

We updated the codebase for Qiling and Unicorn since this issue being posted.

Feel free to try the latest version.

@xwings xwings closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants