Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #32

Closed
felipenoris opened this issue Apr 24, 2019 · 10 comments
Closed

Update deps #32

felipenoris opened this issue Apr 24, 2019 · 10 comments

Comments

@felipenoris
Copy link

I would recommend update deps for XLSX v0.5 .
This would be a good time to switch to the new Project.toml thing for queryverse packages.

Let me know if you need help with this. I could send PRs for that, but maybe you want to do it on your own.

@davidanthoff
Copy link
Member

Alright, I migrated every package in Queryverse over to Project.toml, including this one here :)

Was XLSX 0.5 a breaking release in some way? Or would we expect that ExcelFiles should be working with XLSX 0.5 and with older versions? In the latter case, we don't need to update anything here, right?

@felipenoris
Copy link
Author

Yes, it is non-breaking regarding the API. But I dropped support for Julia v0.7 .

@davidanthoff
Copy link
Member

I also dropped 0.7 support. So I think we can just leave everything as is now and folks should just get the latest version of things automatically, right?

@felipenoris
Copy link
Author

Yes. You specified XLSX = "≥ 0.4.1" in the project file. Whenever a user executes Pkg.update(), user's manifest file will be updated with the latest XLSX version, if that satisfies other dependencies rules.

@davidanthoff
Copy link
Member

I’m actually not happy with these bounds at all, I’d much prefer to use standard semver here. But I think that is really only practical once packages have a major version of 1. So at least for queryverse I’m just releasing 1.0 for everything now. It would be great if one could somehow say that any XLXS version larger than X but smaller than 1.0.0 would be ok...

@felipenoris
Copy link
Author

felipenoris commented Apr 27, 2019

The way I'm working right now for XLSX, you could set XLSX = "^0.5.0" which targets version numbers in the range [0.5.0, 0.6.0).

Once I tag a v0.6 version, there will be some breaking change comparing to v0.5 . This is equivalent to consider 0.5 to 0.6 a MAJOR change, and 0.5.0 to 0.5.1 a MINOR or PATCH change, regarding semver.

I think I'll take quite some time to reach v1.0 on this one. This is very subjective (and maybe silly) thing, but I find that other packages work that way as well.

@felipenoris
Copy link
Author

felipenoris commented Apr 27, 2019

Also, if you take a look at Project.toml in XLSX.jl, you'll find that I don't set any restrictions on dependencies. I leave to the user's Manifest.toml file to act as the safety net. The tradeoff is that I don't micromanage dependencies, but I must check regularly for broken tests after a Pkg.update().

@davidanthoff
Copy link
Member

I wish there was just clear guidelines of what packages should do in this new world. I'd just like to do whatever the recommended julia way is, and not even think about it :)

@davidanthoff
Copy link
Member

But in any case, I think with the clear strategy that you have for XLSX, I'll do the thing you suggest above.

@felipenoris
Copy link
Author

Well, I prefer to keep my comments to myself after all the trouble I got into in that discourse thread. 😄

But feel free to hint me if you need anything in another direction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants