From 10d0bc2dc5198eecdcae2176a946bc826cab481e Mon Sep 17 00:00:00 2001
From: Mohamed El Mahallawy <mmahalwy@gmail.com>
Date: Wed, 9 Nov 2016 22:47:04 -0800
Subject: [PATCH] PR feedback

---
 Dockerfile                              |  2 ++
 src/components/IndexHeader/Nav/index.js |  7 +++----
 src/containers/Login/index.js           | 19 ++++++-------------
 src/containers/Profile/index.js         |  4 ++--
 src/types/userType.js                   | 13 +++++++++++++
 5 files changed, 26 insertions(+), 19 deletions(-)
 create mode 100644 src/types/userType.js

diff --git a/Dockerfile b/Dockerfile
index e3f6568dc..ead4f6e3d 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -4,6 +4,8 @@ ENV NODE_ENV production
 ENV API_URL http://api.quran.com:3000
 ENV SENTRY_KEY_CLIENT https://44c105328ae544ae9928f9eb74b40061@app.getsentry.com/80639
 ENV SENTRY_KEY_SERVER https://44c105328ae544ae9928f9eb74b40061:41ca814d33124e04ab450104c3938cb1@app.getsentry.com/80639
+# It's okay because it's only the APP ID
+ENV FACEBOOK_APP_ID 1557596491207315
 ENV PORT 8000
 ENV NODE_PATH "./src"
 
diff --git a/src/components/IndexHeader/Nav/index.js b/src/components/IndexHeader/Nav/index.js
index cdb076cdb..55396965c 100644
--- a/src/components/IndexHeader/Nav/index.js
+++ b/src/components/IndexHeader/Nav/index.js
@@ -2,7 +2,6 @@ import React, { Component, PropTypes } from 'react';
 import Link from 'react-router/lib/Link';
 import { connect } from 'react-redux';
 
-
 export class IndexHeaderNav extends Component {
   static propTypes = {
     user: PropTypes.object
@@ -12,15 +11,15 @@ export class IndexHeaderNav extends Component {
     open: false
   };
 
-  openNav(e) {
-    e.preventDefault();
+  openNav(event) {
+    event.preventDefault();
 
     this.setState({open: !this.state.open});
   }
 
   links() {
     const { user } = this.props;
-    let classNames = `links ${this.state.open ? 'open' : ''}`;
+    const classNames = `links ${this.state.open ? 'open' : ''}`;
 
     return (
       <ul className={classNames}>
diff --git a/src/containers/Login/index.js b/src/containers/Login/index.js
index 492fa53ed..16f8c67b2 100644
--- a/src/containers/Login/index.js
+++ b/src/containers/Login/index.js
@@ -1,16 +1,9 @@
-import React, { Component } from 'react';
+import React from 'react';
 
 import FacebookButton from 'components/FacebookButton';
 
-export default class Login extends Component {
-  something() {
-
-  }
-  render() {
-    return (
-      <div>
-        <FacebookButton />
-      </div>
-    );
-  }
-}
+export default () => (
+  <div>
+    <FacebookButton />
+  </div>
+);
diff --git a/src/containers/Profile/index.js b/src/containers/Profile/index.js
index 7c29e964e..9977b82d6 100644
--- a/src/containers/Profile/index.js
+++ b/src/containers/Profile/index.js
@@ -7,6 +7,7 @@ import Col from 'react-bootstrap/lib/Col';
 import Image from 'react-bootstrap/lib/Image';
 
 import QuranNav from 'components/QuranNav';
+import userType from 'types/userType';
 
 const styles = require('./style.scss');
 
@@ -17,10 +18,9 @@ const styles = require('./style.scss');
 )
 export default class Profile extends Component {
   static propTypes = {
-    user: PropTypes.object
+    user: PropTypes.shape(userType)
   };
 
-  something() {}
   render() {
     const { user } = this.props;
 
diff --git a/src/types/userType.js b/src/types/userType.js
new file mode 100644
index 000000000..ff4bee81b
--- /dev/null
+++ b/src/types/userType.js
@@ -0,0 +1,13 @@
+import { PropTypes } from 'react';
+
+export default {
+  provider: PropTypes.string,
+  uid: PropTypes.string,
+  firstName: PropTypes.string,
+  lastName: PropTypes.string,
+  username: PropTypes.string,
+  link: PropTypes.string,
+  image: PropTypes.string,
+  email: PropTypes.string,
+  name: PropTypes.string
+};