Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Cleanup settings #580

Closed
4 tasks done
umairidris opened this issue Jan 12, 2017 · 5 comments
Closed
4 tasks done

Cleanup settings #580

umairidris opened this issue Jan 12, 2017 · 5 comments

Comments

@umairidris
Copy link
Contributor

umairidris commented Jan 12, 2017

  • Add settings page and link to nav drawer (or put it under the "three dot" dropdown in app bar)
  • Move language settings from footer to settings
  • Move reciters, translations, tooltip setting
  • Remove search from nav drawer

Sample: http://i.imgur.com/JroM2lH.png

@mmahalwy
Copy link
Contributor

+1

@umairidris
Copy link
Contributor Author

My next couple of weeks are bit busy but I am going to start contributing to the UI efforts by working on the settings page.

@mmahalwy
Copy link
Contributor

mmahalwy commented Jan 16, 2017

@umairidris might beat you to it since all this is blocking deploying. Since we are unhappy with the drawer.

Also, might make it a modal. A whole page might not be needed for it.

@umairidris
Copy link
Contributor Author

umairidris commented Jan 16, 2017

You can see some of the groundwork I was doing here: https://github.com/umairidris/quran.com-frontend/tree/settingspage

May help! I will let you continue from here. It makes sense to get the basics done (not everything needs to be done right away) and things can be tweaked/improved for future releases when the groundwork is laid.

p.s. I am seeing a lot of new warnings, was some sort of checker enabled?

@mmahalwy
Copy link
Contributor

Keeping font size out of settings modal. Might make sense to have it more accessible?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants