Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no attache release notes in Drafted build, Although everything has been done in right way. #220

Open
m-mostafa-gotrah opened this issue May 23, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@m-mostafa-gotrah
Copy link

Describe the bug
I upload a drafted build into internal track but, there is no attached release notes and I checked the logs and everything works fine.

Workflow Step Configuration

- name: Deploy to Play Store
        id: deploy
        uses: r0adkll/upload-google-play@v1.1.3
        with:
          serviceAccountJson: service_account.json
          packageName: com.xxx
          releaseFiles: app/build/outputs/bundle/release/app-release.aab
          track: internal
          whatsNewDirectory: distribution/whatsnew
          status: draft
          mappingFile: app/build/outputs/mapping/release/mapping.txt

Step Debugging

##[debug]Evaluating condition for step: 'Deploy to Play Store (internal)'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Deploy to Play Store (internal)
##[debug]Loading inputs
##[debug]Evaluating: github.event.inputs.track
##[debug]Evaluating Index:
##[debug]..Evaluating Index:
##[debug]....Evaluating Index:
##[debug]......Evaluating github:
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'event'
##[debug]....=> Object
##[debug]....Evaluating String:
##[debug]....=> 'inputs'
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'track'
##[debug]=> 'internal'
##[debug]Result: 'internal'
##[debug]Loading env
Run r0adkll/upload-google-play@v1.1.3
Creating a new Edit for this release
##[debug]This new edit expires at 1716[2](https://github.com/xxx/xxx-android/actions/runs/9172443408/job/25219504947#step:13:2)92830
Validating track 'internal'
Uploading app/build/outputs/bundle/release/app-release.aab
##[debug][1[3](https://github.com/xxx/xxx-android/actions/runs/9172443408/job/25219504947#step:13:3)243175695929076052, packageName=com.***]: Uploading App Bundle @ app/build/outputs/bundle/release/app-release.aab
##[debug][132[4](https://github.com/xxx/xxx-android/actions/runs/9172443408/job/25219504947#step:13:4)3175695929076052, versionCode=[5](https://github.com/xxx/xxx-android/actions/runs/9172443408/job/25219504947#step:13:5)8, packageName=com.***]: Uploading Proguard mapping file @ app/build/outputs/mapping/release/mapping.txt
Successfully uploaded 1 artifacts
##[debug]Creating release for:
##[debug]edit=13243175[6](https://github.com/xxx/xxx-android/actions/runs/9172443408/job/25219504947#step:13:6)95929076052
##[debug]track=internal
##[debug]status=draft
##[debug]versionCodes=58
##[debug]Executing readLocalizedReleaseNotes
##[debug]Found files: whatsnew-en-US
##[debug]Matches for whatsnew-en-US = whatsnew-en-US,en-US,en-US,
##[debug]Found localized 'whatsnew-*-*' for Lang(en-US)
Committing the Edit
Successfully committed 132431[7](https://github.com/xxx/xxx-android/actions/runs/9172443408/job/25219504947#step:13:7)5695929076052
Finished uploading to the Play Store: 13243175695929076052
##[debug]Node Action run completed with exit code 0
##[debug]GOOGLE_APPLICATION_CREDENTIALS='service_account.json'
##[debug]INTERNAL_SHARING_DOWNLOAD_URL='https://play.google.com/apps/test/com.***/5[8](https://github.com/xxx/xxx-android/actions/runs/9172443408/job/25219504947#step:13:8)'
##[debug]Set output internalSharingDownloadUrl = https://play.google.com/apps/test/com.***/58
##[debug]Finishing: Deploy to Play Store (internal)

Step Debugging For LocalizedReleaseNotes

##[debug]Executing readLocalizedReleaseNotes
##[debug]Found files: whatsnew-en-US
##[debug]Matches for whatsnew-en-US = whatsnew-en-US,en-US,en-US,
##[debug]Found localized 'whatsnew-*-*' for Lang(en-US)
Committing the Edit
Successfully committed 132431[7](https://github.com/xxx/xxx-android/actions/runs/9172443408/job/25219504947#step:13:7)5695929076052
Finished uploading to the Play Store: 13243175695929076052
##[debug]Node Action run completed with exit code 0
##[debug]GOOGLE_APPLICATION_CREDENTIALS='service_account.json'
##[debug]INTERNAL_SHARING_DOWNLOAD_URL='https://play.google.com/apps/test/com.***/5[8](https://github.com/xxx/xxx-android/actions/runs/9172443408/job/25219504947#step:13:8)'
##[debug]Set output internalSharingDownloadUrl = https://play.google.com/apps/test/com.***/58
##[debug]Finishing: Deploy to Play Store (internal)
@m-mostafa-gotrah m-mostafa-gotrah added the bug Something isn't working label May 23, 2024
@boswelja
Copy link
Collaborator

boswelja commented Aug 7, 2024

Apologies for the late response. Is this still an issue? I see from the logs that the action is working correctly, so I'm wondering if this was a bug/behavior with Google Play APIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants