Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why did we rename PipelineConfigError ? #155

Closed
tristpinsm opened this issue Jan 13, 2021 · 4 comments · Fixed by #156
Closed

Why did we rename PipelineConfigError ? #155

tristpinsm opened this issue Jan 13, 2021 · 4 comments · Fixed by #156
Assignees

Comments

@tristpinsm
Copy link
Contributor

tristpinsm commented Jan 13, 2021

commit 8f22399 replaced PipelineConfigError with CaputConfigError. There are at least a few instances of this exception being used outside of caput (it is public after all), which are now broken.

e.g.

$grep -r PipelineConfigError draco
draco/core/io.py:                raise pipeline.PipelineConfigError(
grep: draco/core/io.pyc: binary file matches
grep: draco/core/task.pyc: binary file matches
draco/core/task.py:            raise pipeline.PipelineConfigError(msg)

also in the beam code in ch_pipeline (which is where I noticed this)

@jrs65
Copy link
Contributor

jrs65 commented Jan 13, 2021

I think the ones in draco are changed in a corresponding PR that should have been merged by now. I'm not sure ch_pipeline was checked though. @nritsche maybe add an alias in caput for PipelineConfigError = CaputConfigError, or add it back in but make it deprecated?

@tristpinsm
Copy link
Contributor Author

I pulled the latest version of master on draco (radiocosmology/draco@43914e3) before checking.

@jrs65
Copy link
Contributor

jrs65 commented Jan 13, 2021

Oh oops. I guess Rick didn't catch everything. What was the rationale for the rename in the first place?

@nritsche
Copy link
Contributor

Oh oops. I guess Rick didn't catch everything. What was the rationale for the rename in the first place?

...adding config file line numbers to the error output, I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants