Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept top-level ".bobconfig" for repo globals #97

Open
rafecolton opened this issue Jul 28, 2014 · 2 comments
Open

Accept top-level ".bobconfig" for repo globals #97

rafecolton opened this issue Jul 28, 2014 · 2 comments

Comments

@rafecolton
Copy link
Owner

Since the user has limited control over the data sent with a Travis/GitHub webhook, certain options will have to be specified statically in the repo.

The suggested implementation for this is a .bobconfig file at the top level of the repo. Example options to be included in the .bobconfig are the default Bobfile and container group to be built (ala #96)

@jszwedko
Copy link
Contributor

What line would we draw between what should be in .bobconfig vs what goes in the Bobfile?

@rafecolton
Copy link
Owner Author

So for sure the things that are specific to build-time would go in there. For example, we can't set a default Bobfile in the Bobfile itself. Setting the container group in there also makes sense, as that refers to which container(s) we build, not what groups are applied to the [[container]] sections.

After that, I'm not sure. There are some things that would seem handy to put in there like the docker registry credentials. However, that doesn't really fit the "specific to build-time" criteria, and I would like to avoid added complexity that would come from having too many levels of precedence. We already have a lot with [[container]] > [container_globals] > command-line options > environment vars

What are your thoughts on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants