Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Error Audit] Category 2 error messages clean-up #2693

Closed
1 of 7 tasks
ADPennington opened this issue Sep 5, 2023 · 3 comments · Fixed by #2963
Closed
1 of 7 tasks

[Error Audit] Category 2 error messages clean-up #2693

ADPennington opened this issue Sep 5, 2023 · 3 comments · Fixed by #2963
Assignees
Labels
dev Parity Work associated with TDP Parity QASP Review Refined Ticket has been refined at the backlog refinement

Comments

@ADPennington
Copy link
Collaborator

ADPennington commented Sep 5, 2023

Description
Delivers Category 2 error language fixes

Acceptance Criteria:

  • All Cat2 errors should include the [Item #][Friendly Name] pattern (see run_field_validators in row schema)
  • All Cat 2 errors are consistent with desired outputs in the HackMD table
  • Misc cleanups are fixed:
    • validateRace error message typo fix Desired output: f"{value} is not greater than or equal to 0 or smaller than or equal to 2.

Tasks:

  • Correct row schema to add Item/Friendly names to Cat2 errors
  • Correct misc cleanup re: validateRace
  • Correct other issues noted in Hack.md table which includes validators oneOf, notOneOf, isInStringRange, isNumber

Supporting Documentation:

@ADPennington ADPennington changed the title fix this validator language in tanf section 1, t2 Category 2 error messages clean-up Dec 27, 2023
@ADPennington ADPennington changed the title Category 2 error messages clean-up [WIP] Category 2 error messages clean-up Dec 27, 2023
@ADPennington ADPennington mentioned this issue Feb 18, 2024
31 tasks
@robgendron robgendron added the Parity Work associated with TDP Parity label Apr 8, 2024
@robgendron
Copy link

@reitermb @andrew-jameson need more detail to implement - AC is specific, Hackmd is not. Let's build out more tasks and pull out what is needed to do the work from the hackmd (tables, etc.) and put it in the ticket (not hyperlinked).

@robgendron robgendron added the dev label Apr 22, 2024
@reitermb
Copy link

Removing the following AC for the moment, I believe they originally referred to errors that will be corrected by other work including #2688. Quoting here in case we need to refine into this/other tickets

  • intHasLength
  • dateYearIsLargerThan
  • dateMonthIsValid
  • dateDayIsValid

@reitermb reitermb changed the title [WIP] Category 2 error messages clean-up [Error Audit] Category 2 error messages clean-up Apr 23, 2024
@reitermb reitermb removed the WIP label Apr 23, 2024
@robgendron robgendron added the Refined Ticket has been refined at the backlog refinement label Apr 23, 2024
@reitermb reitermb removed their assignment Apr 24, 2024
@jtimpe jtimpe assigned jtimpe and unassigned ADPennington Apr 25, 2024
@jtimpe
Copy link

jtimpe commented Apr 26, 2024

Item 37 (Education level) must be in range of values [01-16] or in set of values [98, 99] | Above issue of missing item number + missing ranges/sets/both of allowable values. We might have a little bit of a broader issue here with fields that are not required serving up errors saying they're required. If it's a space fill issue it should not produce an error indicating that it's a missing value.

education level is already optional so the cat3 validator is what's returning here, #2821 would cover this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Parity Work associated with TDP Parity QASP Review Refined Ticket has been refined at the backlog refinement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants