-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base ConnectionConfigModel Not Deserializing #363
Comments
I'm debugging through locally to try to find a solution. Posting here in case you know a quick fix. Thanks! |
Are all base properties null? The System.Text.Json custom converters seem to be problematic if used via attributes. (vs programmatically) |
Any base property that didn't have a default in the class appears null, yes. I do see the value in the |
I followed your comment in the |
thanks , that is very helpful. I think it is not a deser issue. The structure of the connection object between the write and read seems to be different. The read structure is as follows: https://developer.hashicorp.com/vault/api-docs/secret/databases#sample-response Thats the problem. I'll release a fix with the right model tomorrow. |
Oh! I think I see it. The JSON structure is slightly different than expected.
Looks like |
@treyhendon I prepared a local fix. Which version of .NET are you using? i'll give you a DLL for temp testing here, before releasing a nuget |
I'm using .net 8. Thanks! |
please use this dll and let me know. |
I actually just pulled your master branch and was able to successfully test! I'll download the dll and try that as well. Thanks! |
Ah cool. I forget that folks can easily build from the project as well. |
I can also confirm the .net 8 dll is a success. Thanks again for such a quick response! |
Cool, good to hear. I'll publish the official nuget in a day. It's my bad, I overlooked the read Api response model. |
VaultSharp/src/VaultSharp/V1/SecretsEngines/Database/ConnectionConfigModelJsonConverter.cs
Line 109 in 4f906a9
PostgreSQLConnectionConfigModel
is properly being deserialized, but base properties fromConnectionConfigModel
(i.e. connection_url, username, password) are null in the returnedSecret<ConnectionConfigModel>
.The text was updated successfully, but these errors were encountered: