diff --git a/.github/workflows/release_prep.sh b/.github/workflows/release_prep.sh index ca5859e..b772d10 100755 --- a/.github/workflows/release_prep.sh +++ b/.github/workflows/release_prep.sh @@ -37,3 +37,11 @@ http_archive( EOF awk 'f;/--SNIP--/{f=1}' e2e/smoke/WORKSPACE.bazel echo "\`\`\`" + +cat << EOF +To use rules_esbuild with bazel-lib 2.0, you must additionally register the coreutils toolchain. +\`\`\`starlark +load("@aspect_bazel_lib//lib:repositories.bzl", "register_coreutils_toolchains") +register_coreutils_toolchains() +\`\`\` +EOF \ No newline at end of file diff --git a/MODULE.bazel b/MODULE.bazel index 6cc146a..aa790bb 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -10,7 +10,7 @@ bazel_dep(name = "bazel_skylib", version = "1.4.1") bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.4.1", dev_dependency = True) bazel_dep(name = "gazelle", version = "0.29.0", dev_dependency = True, repo_name = "bazel_gazelle") bazel_dep(name = "buildifier_prebuilt", version = "6.0.0.1", dev_dependency = True) -bazel_dep(name = "aspect_bazel_lib", version = "1.29.2") +bazel_dep(name = "aspect_bazel_lib", version = "1.38.1") bazel_dep(name = "aspect_rules_js", version = "1.29.2") bazel_dep(name = "rules_nodejs", version = "5.8.2") bazel_dep(name = "platforms", version = "0.0.5") diff --git a/esbuild/private/esbuild.bzl b/esbuild/private/esbuild.bzl index fec42e0..9ea2504 100644 --- a/esbuild/private/esbuild.bzl +++ b/esbuild/private/esbuild.bzl @@ -1,7 +1,7 @@ "# esbuild rule" load("@aspect_bazel_lib//lib:expand_make_vars.bzl", "expand_variables") -load("@aspect_bazel_lib//lib:copy_to_bin.bzl", "copy_file_to_bin_action", "copy_files_to_bin_actions") +load("@aspect_bazel_lib//lib:copy_to_bin.bzl", "copy_file_to_bin_action", "copy_files_to_bin_actions", "COPY_FILE_TO_BIN_TOOLCHAINS") load("@aspect_rules_js//js:libs.bzl", "js_lib_helpers") load("@aspect_rules_js//js:providers.bzl", "JsInfo", "js_info") load(":helpers.bzl", "desugar_entry_point_names", "write_args_file") @@ -422,7 +422,7 @@ lib = struct( toolchains = [ "@rules_nodejs//nodejs:toolchain_type", "@aspect_rules_esbuild//esbuild:toolchain_type", - ], + ] + COPY_FILE_TO_BIN_TOOLCHAINS, ) esbuild_bundle = rule(