From bb1b35196e3b192b56a907cdc6acf017f850763f Mon Sep 17 00:00:00 2001
From: Akhilesh Samineni <47657796+AkhileshSamineni@users.noreply.github.com>
Date: Wed, 16 Dec 2020 07:04:52 +0530
Subject: [PATCH] [201911] Fixes for NAT lgtm alerts (#1391)

This PR is similar as #1320 which is merged on master branch.

Signed-off-by: Akhilesh Samineni akhilesh.samineni@broadcom.com
---
 cfgmgr/natmgr.cpp    | 2 +-
 natsyncd/natsync.cpp | 8 ++++++++
 natsyncd/natsync.h   | 1 +
 3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/cfgmgr/natmgr.cpp b/cfgmgr/natmgr.cpp
index 894496122edb..200acdfd8091 100644
--- a/cfgmgr/natmgr.cpp
+++ b/cfgmgr/natmgr.cpp
@@ -4113,7 +4113,7 @@ void NatMgr::setDynamicAllForwardOrAclbasedRules(const string &opCmd, const stri
         /* After deletion, set acl_interface to None */  
         if (opCmd == DELETE)
         {
-            m_natBindingInfo[dynamicKey].acl_interface == NONE_STRING;
+            m_natBindingInfo[dynamicKey].acl_interface = NONE_STRING;
         }
     }
 
diff --git a/natsyncd/natsync.cpp b/natsyncd/natsync.cpp
index 1db37c5c2626..c8fe3a804163 100644
--- a/natsyncd/natsync.cpp
+++ b/natsyncd/natsync.cpp
@@ -61,6 +61,14 @@ NatSync::NatSync(RedisPipeline *pipelineAppDB, DBConnector *appDb, DBConnector *
     }
 }
 
+NatSync::~NatSync()
+{
+    if (m_AppRestartAssist)
+    {
+        delete m_AppRestartAssist;
+    }
+}
+
 /* To check the port init is done or not */
 bool NatSync::isPortInitDone(DBConnector *app_db)
 {
diff --git a/natsyncd/natsync.h b/natsyncd/natsync.h
index e4ea8c6f1823..27e4cb9c0d9d 100644
--- a/natsyncd/natsync.h
+++ b/natsyncd/natsync.h
@@ -43,6 +43,7 @@ class NatSync : public NetMsg
 {
 public:
     NatSync(RedisPipeline *pipelineAppDB, DBConnector *appDb, DBConnector *stateDb, NfNetlink *nfnl);
+    ~NatSync();
 
     virtual void onMsg(int nlmsg_type, struct nl_object *obj);