From fdf36ad45aa29c3cd423ece89ea1baed12af42a7 Mon Sep 17 00:00:00 2001 From: Gera Shegalov Date: Tue, 1 Oct 2024 17:50:43 -0700 Subject: [PATCH] Revert "nvCOMP GZIP integration (#16770)" This reverts commit 750adca4e4cc7b18ef80ba39950ed1d250919016. --- cpp/include/cudf/io/nvcomp_adapter.hpp | 2 +- cpp/src/io/comp/nvcomp_adapter.cpp | 5 +---- cpp/src/io/parquet/reader_impl_chunking.cu | 14 ++------------ docs/cudf/source/user_guide/io/io.md | 6 +----- 4 files changed, 5 insertions(+), 22 deletions(-) diff --git a/cpp/include/cudf/io/nvcomp_adapter.hpp b/cpp/include/cudf/io/nvcomp_adapter.hpp index 606b8a6eb90..f3260d0cb53 100644 --- a/cpp/include/cudf/io/nvcomp_adapter.hpp +++ b/cpp/include/cudf/io/nvcomp_adapter.hpp @@ -24,7 +24,7 @@ namespace CUDF_EXPORT cudf { namespace io::nvcomp { -enum class compression_type { SNAPPY, ZSTD, DEFLATE, LZ4, GZIP }; +enum class compression_type { SNAPPY, ZSTD, DEFLATE, LZ4 }; /** * @brief Set of parameters that impact whether nvCOMP features are enabled. diff --git a/cpp/src/io/comp/nvcomp_adapter.cpp b/cpp/src/io/comp/nvcomp_adapter.cpp index 514e8525222..3191e8f015c 100644 --- a/cpp/src/io/comp/nvcomp_adapter.cpp +++ b/cpp/src/io/comp/nvcomp_adapter.cpp @@ -134,8 +134,6 @@ auto batched_decompress_async(compression_type compression, Args&&... args) nvcomp::is_decompression_disabled(nvcomp::compression_type::DEFLATE).value()); #endif case compression_type::LZ4: return nvcompBatchedLZ4DecompressAsync(std::forward(args)...); - case compression_type::GZIP: - return nvcompBatchedGzipDecompressAsync(std::forward(args)...); default: CUDF_FAIL("Unsupported compression type"); } } @@ -147,7 +145,6 @@ std::string compression_type_name(compression_type compression) case compression_type::ZSTD: return "Zstandard"; case compression_type::DEFLATE: return "Deflate"; case compression_type::LZ4: return "LZ4"; - case compression_type::GZIP: return "GZIP"; } return "compression_type(" + std::to_string(static_cast(compression)) + ")"; } @@ -547,8 +544,8 @@ std::optional is_compression_disabled_impl(compression_type compres "environment variable."; } return std::nullopt; - default: return "Unsupported compression type"; } + return "Unsupported compression type"; } std::optional is_compression_disabled(compression_type compression, diff --git a/cpp/src/io/parquet/reader_impl_chunking.cu b/cpp/src/io/parquet/reader_impl_chunking.cu index c588fedb85c..bab70c126b3 100644 --- a/cpp/src/io/parquet/reader_impl_chunking.cu +++ b/cpp/src/io/parquet/reader_impl_chunking.cu @@ -865,18 +865,8 @@ std::vector compute_page_splits_by_row(device_span + **Notes:** - \[¹\] - Not all orientations are GPU-accelerated. @@ -176,9 +177,4 @@ If no value is set, behavior will be the same as the "STABLE" option. +-----------------------+--------+--------+--------------+--------------+---------+--------+--------------+--------------+--------+ | DEFLATE | ❌ | ❌ | ❌ | ❌ | ❌ | ❌ | Experimental | Experimental | ❌ | +-----------------------+--------+--------+--------------+--------------+---------+--------+--------------+--------------+--------+ - | LZ4 | ❌ | ❌ | Stable | Stable | ❌ | ❌ | Stable | Stable | ❌ | - +-----------------------+--------+--------+--------------+--------------+---------+--------+--------------+--------------+--------+ - | GZIP | ❌ | ❌ | Experimental | Experimental | ❌ | ❌ | ❌ | ❌ | ❌ | - +-----------------------+--------+--------+--------------+--------------+---------+--------+--------------+--------------+--------+ - ```