Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Design and implement cudf::scalar #2914

Closed
harrism opened this issue Oct 2, 2019 · 2 comments · Fixed by #3068
Closed

[FEA] Design and implement cudf::scalar #2914

harrism opened this issue Oct 2, 2019 · 2 comments · Fixed by #3068
Assignees
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Comments

@harrism
Copy link
Member

harrism commented Oct 2, 2019

Is your feature request related to a problem? Please describe.

With the first phase of the libcudf core data structure redesign in place (#2207), we need to add a scalar type, cudf::scalar to replace the legacy gdf_scalar struct.

Describe the solution you'd like

cudf::scalar needs to support all the types gdf_scalar supports, as well as string and category scalar values. I think a good test of gdf_scalar is whether it can be used to cudf::fill() a column of any type.

I'm sure @jrhemstad has thoughts on design to share.

@harrism harrism added feature request New feature or request Needs Triage Need team to review and classify labels Oct 2, 2019
@jrhemstad
Copy link
Contributor

Unlike with column_views, for cudf::scalar, I'd like to use a derived class pattern to implement cudf::scalar. We will pass cudf::scalar into libcudf APIs via a base class const&, and then cast to the appropriate derived class via the type dispatcher.

@jrhemstad
Copy link
Contributor

jrhemstad commented Oct 2, 2019

I'd like to effectively emulate Arrow Scalar for this.

@harrism harrism added libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS and removed Needs Triage Need team to review and classify labels Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants