Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Port Binary Ops to cudf::column types #2933

Closed
harrism opened this issue Oct 3, 2019 · 1 comment
Closed

[FEA] Port Binary Ops to cudf::column types #2933

harrism opened this issue Oct 3, 2019 · 1 comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Comments

@harrism
Copy link
Member

harrism commented Oct 3, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.

Now that #2207 is merged we need to start porting functionality to use it. This issue covers functionality defined in cudf/binaryop.hpp.

Describe the solution you'd like

Update the API functions definitions in cudf/binaryop.hpp and their implementations to use the new cudf::column and associated classes.

Note that until string columns and other wrapper types are supported, operations will only be able to be implemented for numerical columns. Initially the "legacy" APIs should be kept in place but moved to the cudf/legacy folder and if necessary a legacy namespace.
@harrism harrism added feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. tech debt labels Oct 3, 2019
@harrism harrism added the Spark Functionality that helps Spark RAPIDS label Oct 4, 2019
@harrism
Copy link
Member Author

harrism commented Dec 6, 2019

Fixed by #3507

@harrism harrism closed this as completed Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@harrism