Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Port cuIO JSON reader to cudf::column types #3521

Closed
mjsamoht opened this issue Dec 4, 2019 · 2 comments
Closed

[FEA] Port cuIO JSON reader to cudf::column types #3521

mjsamoht opened this issue Dec 4, 2019 · 2 comments
Assignees
Labels
cuIO cuIO issue feature request New feature or request

Comments

@mjsamoht
Copy link
Contributor

mjsamoht commented Dec 4, 2019

Is your feature request related to a problem? Please describe.
This issue tracks the effort for moving the cuIO JSON reader to using the new column design and associated infrastructure. It is a continuation of #2954 where all other cuIO readers and writers were moved in release 0.11.

Describe the solution you'd like
Currently, cuIO JSON reader uses wrappers around the C-style gdf_column to aid in storing/accessing column metadata and allocating/deallocating memory. We should be able to get rid of the custom C++ wrappers and directly use the cudf::column and cudf::table.

Describe alternatives you've considered
We may or may not need some sort of temporary wrapper or custom column class still within cuIO to temporary hold column metadata that's format-specific, for delayed column creation to save memory or other usage. The returned columns will be cudf::column and cudf::table though.

Additional context
See other porting efforts for libcudf.

@mjsamoht
Copy link
Contributor Author

@nvdbaranec are you still working on this?

@nvdbaranec
Copy link
Contributor

Yes. Hoping to put up a PR today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuIO cuIO issue feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants