Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CAGRA search call hierarchy #343

Open
achirkin opened this issue Sep 24, 2024 · 0 comments
Open

Simplify CAGRA search call hierarchy #343

achirkin opened this issue Sep 24, 2024 · 0 comments
Assignees
Labels
improvement Improves an existing functionality

Comments

@achirkin
Copy link
Contributor

Past several major code updates since RAFT release (latest change #296) parts of CAGRA search code have become unnecessary complicated or obsolete.

  • neighbors/detail/cagra/factory.cuh once served the instance parameter selection logic (including the non-type template parameters) via the factory class; now this logic can be replaced with a single switch-case block on search_algo.
  • search_params <- search_plan_impl_base <- search_plan_impl <- search is overly complicated for a plain task of choosing between the search algorithms
  • dataset_descriptor_base_t and related types (implementation types and the descriptor host) names are confusing
  • The way the polymorphic behavior is implemented in dataset_descriptor_base_t and its member type args_t is hard to read.
@achirkin achirkin added the improvement Improves an existing functionality label Sep 24, 2024
@achirkin achirkin self-assigned this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant