Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fmt 11.0.2 patch #695

Open
jameslamb opened this issue Sep 24, 2024 · 0 comments
Open

Remove fmt 11.0.2 patch #695

jameslamb opened this issue Sep 24, 2024 · 0 comments
Labels
tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general

Comments

@jameslamb
Copy link
Member

Description

RAPIDS updated to fmt 11.0.2 in #689. To do that, rapids-cmake project took on a patch to suppress warnings from nvcc about a bit of code in fmt being unreachable.

references:

That patch should be removed and fixes upstreamed to the appropriate places (e.g. RAPIDS code, fmt, nvcc).

Benefits of this work

Acceptance Criteria

Approach

First, try to reproduce the error. That could probably be done like this (haven't re-tested as of this writing):

Try to narrow down:

  • version(s) of NVCC?
  • minimal, reproducible example (more minimal than "compile all of cudf")

Submit fixes that'd allow the fmt patch in rapids-cmake to be removed.

Notes

Would also help with these:

@jameslamb jameslamb added the tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general
Projects
None yet
Development

No branches or pull requests

1 participant