Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename rayon_unstable flag #505

Closed
dtolnay opened this issue Jan 3, 2018 · 2 comments
Closed

Rename rayon_unstable flag #505

dtolnay opened this issue Jan 3, 2018 · 2 comments

Comments

@dtolnay
Copy link
Contributor

dtolnay commented Jan 3, 2018

In proc-macro2 we love how rayon_unstable has worked for Rayon and we have adopted a similar RUSTFLAGS-based unstable setting. Discussion where we decided to go this route begins at dtolnay/proc-macro2#36 (comment). We originally called the flag procmacro2_unstable to mimic Rayon.

The problem is we already have a Cargo cfg that enables some things that require a nightly compiler, and this was called --features proc-macro2/unstable. These are basically orthogonal things -- APIs that are still being designed and are exempt from semver but do not require a nightly compiler, and APIs that are semver guaranteed but require nightly features. It was confusing to call both of these things "unstable". Discussion: dtolnay/proc-macro2#42, PR: dtolnay/proc-macro2#44.

We settled on --cfg procmacro2_semver_exempt which is more suggestive of the way in which those things are unstable. Just opening this issue to suggest renaming Rayon's flag to rayon_semver_exempt if you think that would be valuable.

@alexcrichton @mystor

@nikomatsakis
Copy link
Member

I don't have a strong opinion about this -- semver_exempt seems kinda' wordy, but I agree that overloading unstable is perhaps unwise.

@cuviper
Copy link
Member

cuviper commented Feb 27, 2023

We removed that in #716, but if we ever reintroduce it, we could consider a new name.

@cuviper cuviper closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants