Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with CRA 5 #152

Closed
vtrphan opened this issue Dec 21, 2021 · 5 comments
Closed

Compatibility with CRA 5 #152

vtrphan opened this issue Dec 21, 2021 · 5 comments

Comments

@vtrphan
Copy link

vtrphan commented Dec 21, 2021

Is your feature request related to a problem? Please describe.
CRA version 5 is out, also plop and node-plop are gone to a new major version. Will this awesome template be updated accordingly?

@Can-Sahin
Copy link
Member

I will get into this month. I had been busy a lot lately. Thanks for the update

@safranx
Copy link

safranx commented Jan 8, 2022

Hello @Can-Sahin,

When did you expect to "ship/update" your boilerplate with the CRA v5?

Best,

@Can-Sahin
Copy link
Member

Can-Sahin commented Jan 15, 2022

I decided not to update plop.js simply because they have complicated the usage with TS. I will wait until these are resolved. Actually, all the dependencies that became pure ESM modules are delayed intentionally because TS and CRA are not completely ready for this.

So, working on the rest of the dependencies... Should be done in a few days

See the issues: plopjs/plop#192, plopjs/plop#296, plopjs/plop#297, microsoft/TypeScript#46452

@Can-Sahin
Copy link
Member

FYI. I have to wait till CRA fixes this hot issue. Otherwise, I have to add those workarounds to package.json which will be completely obsolete after the fix. I will wait couple of days to see if they are fixing it.

facebook/create-react-app#11930

@Can-Sahin
Copy link
Member

Released and closing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants